Attachment 5961 Details for Bug 6989 – Bug 6989 Patron categories not properly displayed if not pure ASCII

[patch] Bug 6989 Patron categories not properly displayed if not pure ASCII

Bug-6989-Patron-categories-not-properly-displayed-.patch (text/plain), 1.59 KB, created by Paul Poulain on 2011-10-18 16:17:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Poulain

Created: 2011-10-18 16:17:47 UTC

Size: 1.59 KB

patch

obsolete

>From a7cc1dd6abd0298bedb013f81a8d1489b850c17c Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr>
>Date: Sat, 8 Oct 2011 15:30:59 +0200
>Subject: [PATCH] Bug 6989 Patron categories not properly displayed if not
> pure ASCII
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>C4::Category module returns badly encoded patron categories when they are
>containing non pure-ASCII characters.
>
>To reproduce this bug:
>
>  - Go in Administration > Patron Categories
>  - Add a new category. Give it this code for example:
>    CafÃ©
>  - Click on Patrons link on top menu
>  - Click on New button
>
>    => You get 'CafÃ©' displayed without accent
>
>Signed-off-by: Piotr Wejman <ropuch@bagno.be>
>Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
>---
> C4/Category.pm |   13 ++++++-------
> 1 files changed, 6 insertions(+), 7 deletions(-)
>
>diff --git a/C4/Category.pm b/C4/Category.pm
>index b81e88f..8536128 100644
>--- a/C4/Category.pm
>+++ b/C4/Category.pm
>@@ -71,13 +71,12 @@ C<description>.
> =cut
> 
> sub all {
>-    my ($class) = @_;
>-    my $dbh = C4::Context->dbh;
>-    return    map { $class->new($_) }    @{$dbh->selectall_arrayref(
>-        # The categories table is small enough for
>-        # `SELECT *` to be harmless.
>-        "SELECT * FROM categories ORDER BY description",
>-        { Slice => {} },
>+    my $class = shift;
>+    map {
>+        utf8::encode($_->{description});
>+        $class->new($_);
>+    } @{C4::Context->dbh->selectall_arrayref(
>+        "SELECT * FROM categories ORDER BY description", { Slice => {} }
>     )};
> }
> 
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 6989: 5796 | 5840 | 5961