Attachment 5968 Details for Bug 7059 – Proposed Patch

[patch] Proposed Patch

0001-Bug-7059-Remove-GetMemberDetails-from-reserve-reques.patch (text/plain), 2.46 KB, created by Ian Walls on 2011-10-18 22:34:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ian Walls

Created: 2011-10-18 22:34:24 UTC

Size: 2.46 KB

patch

obsolete

>From 2046a10a9f7cde89f6220b310d41a7f0ae5e0623 Mon Sep 17 00:00:00 2001
>From: Ian Walls <ian.walls@bywatersolutions.com>
>Date: Tue, 18 Oct 2011 18:31:00 -0400
>Subject: [PATCH] Bug 7059: Remove GetMemberDetails from reserve/request.pl
>
>Replaces all four usages of GetMemberDetails with GetMember, since none of the
>hashref fields used were anything other than those in borrower table, which GetMember
>returns.
>
>To Test:
>1.  Apply patch
>2.  Go to reserve/request.pl; the page should load without error
>3.  Search for a cardnumber: the page should load without error
>---
> reserve/request.pl |   10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/reserve/request.pl b/reserve/request.pl
>index 5d59e2f..9807ae4 100755
>--- a/reserve/request.pl
>+++ b/reserve/request.pl
>@@ -131,7 +131,7 @@ if ($findborrower) {
> # If we have the borrowernumber because we've performed an action, then we
> # don't want to try to place another reserve.
> if ($borrowernumber_hold && !$action) {
>-    my $borrowerinfo = GetMemberDetails( $borrowernumber_hold );
>+    my $borrowerinfo = GetMember( borrowernumber => $borrowernumber_hold );
>     my $diffbranch;
>     my @getreservloop;
>     my $count_reserv = 0;
>@@ -219,8 +219,8 @@ if ($borrowerslist) {
>     );
> }
> 
>-# FIXME launch another time GetMemberDetails perhaps until
>-my $borrowerinfo = GetMemberDetails( $borrowernumber_hold );
>+# FIXME launch another time GetMember perhaps until
>+my $borrowerinfo = GetMember( borrowernumber => $borrowernumber_hold );
> 
> my @biblionumbers = ();
> my $biblionumbers = $input->param('biblionumbers');
>@@ -375,7 +375,7 @@ foreach my $biblionumber (@biblionumbers) {
> 
>             # checking reserve
>             my ($reservedate,$reservedfor,$expectedAt) = GetReservesFromItemnumber($itemnumber);
>-            my $ItemBorrowerReserveInfo = GetMemberDetails( $reservedfor, 0);
>+            my $ItemBorrowerReserveInfo = GetMember( borrowernumber => $reservedfor );
> 
>             if ( defined $reservedate ) {
>                 $item->{backgroundcolor} = 'reserved';
>@@ -544,7 +544,7 @@ foreach my $biblionumber (@biblionumbers) {
>         }
> 
>         #     get borrowers reserve info
>-        my $reserveborrowerinfo = GetMemberDetails( $res->{'borrowernumber'}, 0);
>+        my $reserveborrowerinfo = GetMember( borrowernumber => $res->{'borrowernumber'} );
>         if (C4::Context->preference('HidePatronName')){
> 	    $reserve{'hidename'} = 1;
> 	    $reserve{'cardnumber'} = $reserveborrowerinfo->{'cardnumber'};
>-- 
>1.7.4.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 7059: 5968 | 5995