Attachment 59687 Details for Bug 13737 – Bug 13757: Make Koha::Patron::Modification->store del empty attrs

[patch] Bug 13757: Make Koha::Patron::Modification->store del empty attrs

Bug-13757-Make-KohaPatronModification-store-del-em.patch (text/plain), 1.56 KB, created by Tomás Cohen Arazi (tcohen) on 2017-01-31 15:59:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-01-31 15:59:33 UTC

Size: 1.56 KB

patch

obsolete

>From 73ff94b233891f98f9067f82f7cff9cd1fcb113a Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 31 Jan 2017 12:41:51 -0300
>Subject: [PATCH] Bug 13757: Make Koha::Patron::Modification->store del empty
> attrs
>
>This patch makes Koha::Patron::Modification->store delete the passed
>attributes that contain empty values.
>
>This is the way it currently works, as all opac-editable attributes are
>presented to the end-user and they are allowed to delete them, and the
>best way I found to represent the deletion on the modification request
>is by setting it to the empty string. I chose this way because it is how
>the staff interface handles it, so it is consistent.
>
>To test:
>- Apply this patch
>- Run:
>  $ prove t/db_dependent/Koha/Patron/Modifications.t
>=> SUCCESS: This time tests pass!
>- Verify comment #70 on the bug is fixed now
>- Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>https://bugs.koha-community.org/show_bug.cgi?id=13737
>---
> Koha/Patron/Modification.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Patron/Modification.pm b/Koha/Patron/Modification.pm
>index e3573ca5ac..718ffe4682 100644
>--- a/Koha/Patron/Modification.pm
>+++ b/Koha/Patron/Modification.pm
>@@ -135,7 +135,8 @@ sub approve {
>                             code           => $attr->{code},
>                             attribute      => $attr->{value}
>                         }
>-                    )->store;
>+                    )->store
>+                        if $attr->{value};
>                 }
>             }
>             catch {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 13737: 59686 | 59687 | 59688