Bugzilla – Attachment 59719 Details for
Bug 17993
Do not use modal authentication with CAS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17993 - Do not use modal authentication with CAS - lists
Bug-17993---Do-not-use-modal-authentication-with-C.patch (text/plain), 2.51 KB, created by
Mark Tompsett
on 2017-02-01 05:12:04 UTC
(
hide
)
Description:
Bug 17993 - Do not use modal authentication with CAS - lists
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-02-01 05:12:04 UTC
Size:
2.51 KB
patch
obsolete
>From 2b9449f5cde412547ec9157525eb06c78b82af76 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 25 Jan 2017 14:19:16 +0100 >Subject: [PATCH] Bug 17993 - Do not use modal authentication with CAS - lists > >Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. >This must also be corrected in link of lists popup : "Log in to create your own lists" > >Test plan : >- Enable syspref casAuthentication >- Go to OPAC >- Click on Lists > Log in to create your own lists >=> Without patch you get the modal login popup >=> With patch you go to the login page opac-user.pl > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 10ea161..9691353 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -71,7 +71,12 @@ > <li role="presentation"><a href="/cgi-bin/koha/opac-shelves.pl?op=list&category=1" tabindex="-1" role="menuitem" class="listmenulink">New list</a></li> > [% END %] > [% ELSE %] >- <li role="presentation"><a href="/cgi-bin/koha/opac-user.pl" tabindex="-1" class="menu-inactive loginModal-trigger" role="menuitem">Log in to create your own lists</a></li> >+ [% IF Koha.Preference('casAuthentication') %] >+ [%# CAS authentication is too complicated for modal window %] >+ <li role="presentation"><a href="/cgi-bin/koha/opac-user.pl" tabindex="-1" class="menu-inactive" role="menuitem">Log in to create your own lists</a></li> >+ [% ELSE %] >+ <li role="presentation"><a href="/cgi-bin/koha/opac-user.pl" tabindex="-1" class="menu-inactive loginModal-trigger" role="menuitem">Log in to create your own lists</a></li> >+ [% END %] > [% END # / IF loggedinusername %] > [% END # / IF opacuserlogin %] > </ul> <!-- / .dropdown-menu --> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17993
:
59549
|
59550
|
59719
|
59720
|
61642
|
62296
|
62867
|
62868
|
62869