Bugzilla – Attachment 59737 Details for
Bug 13757
Make patron attributes editable in the opac if set to 'editable in OPAC'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13757: (regression tests) Empty attributes should delete existing
Bug-13757-regression-tests-Empty-attributes-should.patch (text/plain), 2.34 KB, created by
Tomás Cohen Arazi (tcohen)
on 2017-02-01 13:09:42 UTC
(
hide
)
Description:
Bug 13757: (regression tests) Empty attributes should delete existing
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2017-02-01 13:09:42 UTC
Size:
2.34 KB
patch
obsolete
>From 96c8e22e48dfec3336565ad9b175e78bd5098685 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 31 Jan 2017 12:39:53 -0300 >Subject: [PATCH] Bug 13757: (regression tests) Empty attributes should delete > existing > >This patch introduces tests for the required functionality. > >To test: >- Run: > $ prove t/db_dependent/Koha/Patron/Modifications.t >=> FAIL: The current code doesn't work like that > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >https://bugs.koha-community.org/show_bug.cgi?id=13737 >--- > t/db_dependent/Koha/Patron/Modifications.t | 26 +++++++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Patron/Modifications.t b/t/db_dependent/Koha/Patron/Modifications.t >index 6102316ea0..3ea8aee5fa 100755 >--- a/t/db_dependent/Koha/Patron/Modifications.t >+++ b/t/db_dependent/Koha/Patron/Modifications.t >@@ -132,7 +132,7 @@ subtest 'store( extended_attributes ) tests' => sub { > > subtest 'approve tests' => sub { > >- plan tests => 14; >+ plan tests => 18; > > $schema->storage->txn_begin; > >@@ -224,6 +224,30 @@ subtest 'approve tests' => sub { > is( $patron_attributes[2]->{attribute}, > 'None', 'Attribute updated correctly (attribute)' ); > >+ my $empty_code_json = '[{"code":"CODE_2","value":""}]'; >+ $verification_token = md5_hex( time() . {} . rand() . {} . $$ ); >+ >+ $patron_modification = Koha::Patron::Modification->new( >+ { borrowernumber => $patron->borrowernumber, >+ extended_attributes => $empty_code_json, >+ verification_token => $verification_token >+ } >+ )->store(); >+ ok( $patron_modification->approve, >+ 'Patron modification correctly approved' ); >+ @patron_attributes >+ = map { $_->unblessed } >+ Koha::Patron::Attributes->search( >+ { borrowernumber => $patron->borrowernumber } ); >+ >+ is( $patron_attributes[0]->{code}, >+ 'CODE_1', 'Untouched attribute type is preserved (code)' ); >+ is( $patron_attributes[0]->{attribute}, >+ 'VALUE_1', 'Untouched attribute type is preserved (attribute)' ); >+ >+ my $count = Koha::Patron::Attributes->search({ borrowernumber => $patron->borrowernumber, code => 'CODE_2' })->count; >+ is( $count, 0, 'Attributes deleted when modification contained an empty one'); >+ > $schema->storage->txn_rollback; > }; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13757
:
42254
|
42626
|
42627
|
47625
|
48040
|
48041
|
48042
|
48043
|
48379
|
48380
|
48381
|
48382
|
56924
|
56925
|
56926
|
56927
|
56928
|
56929
|
57041
|
57042
|
57043
|
57044
|
57045
|
57046
|
58252
|
58253
|
58254
|
58255
|
58351
|
58352
|
58353
|
58354
|
58355
|
58356
|
58357
|
58428
|
58429
|
58581
|
58703
|
58706
|
58707
|
58708
|
58709
|
58710
|
58711
|
58712
|
58713
|
58714
|
58715
|
59376
|
59737
|
59738
|
59739
|
59813
|
59896
|
59897
|
59898
|
60359
|
60360
|
61132
|
61133
|
61134
|
61135
|
61136
|
61137
|
61138
|
61139
|
61140
|
61141
|
61142
|
61143
|
61144
|
61145
|
61146
|
61147
|
61148
|
61149
|
61150
|
61492
|
61493
|
61555
|
61556
|
61557
|
61558
|
61559
|
61560
|
61561
|
61562
|
61563
|
61564
|
61565
|
61566
|
61567
|
61568
|
61569
|
61570
|
61571
|
61572
|
61573
|
61574
|
61575