Bugzilla – Attachment 59738 Details for
Bug 13757
Make patron attributes editable in the opac if set to 'editable in OPAC'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13757: Make Koha::Patron::Modification->store del empty attrs
Bug-13757-Make-KohaPatronModification-store-del-em.patch (text/plain), 1.56 KB, created by
Tomás Cohen Arazi (tcohen)
on 2017-02-01 13:09:49 UTC
(
hide
)
Description:
Bug 13757: Make Koha::Patron::Modification->store del empty attrs
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2017-02-01 13:09:49 UTC
Size:
1.56 KB
patch
obsolete
>From 0456c0d1066b15f31c5b36b8c205e53248ad4eae Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 31 Jan 2017 12:41:51 -0300 >Subject: [PATCH] Bug 13757: Make Koha::Patron::Modification->store del empty > attrs > >This patch makes Koha::Patron::Modification->store delete the passed >attributes that contain empty values. > >This is the way it currently works, as all opac-editable attributes are >presented to the end-user and they are allowed to delete them, and the >best way I found to represent the deletion on the modification request >is by setting it to the empty string. I chose this way because it is how >the staff interface handles it, so it is consistent. > >To test: >- Apply this patch >- Run: > $ prove t/db_dependent/Koha/Patron/Modifications.t >=> SUCCESS: This time tests pass! >- Verify comment #70 on the bug is fixed now >- Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >https://bugs.koha-community.org/show_bug.cgi?id=13737 >--- > Koha/Patron/Modification.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/Patron/Modification.pm b/Koha/Patron/Modification.pm >index e3573ca5ac..718ffe4682 100644 >--- a/Koha/Patron/Modification.pm >+++ b/Koha/Patron/Modification.pm >@@ -135,7 +135,8 @@ sub approve { > code => $attr->{code}, > attribute => $attr->{value} > } >- )->store; >+ )->store >+ if $attr->{value}; > } > } > catch { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13757
:
42254
|
42626
|
42627
|
47625
|
48040
|
48041
|
48042
|
48043
|
48379
|
48380
|
48381
|
48382
|
56924
|
56925
|
56926
|
56927
|
56928
|
56929
|
57041
|
57042
|
57043
|
57044
|
57045
|
57046
|
58252
|
58253
|
58254
|
58255
|
58351
|
58352
|
58353
|
58354
|
58355
|
58356
|
58357
|
58428
|
58429
|
58581
|
58703
|
58706
|
58707
|
58708
|
58709
|
58710
|
58711
|
58712
|
58713
|
58714
|
58715
|
59376
|
59737
|
59738
|
59739
|
59813
|
59896
|
59897
|
59898
|
60359
|
60360
|
61132
|
61133
|
61134
|
61135
|
61136
|
61137
|
61138
|
61139
|
61140
|
61141
|
61142
|
61143
|
61144
|
61145
|
61146
|
61147
|
61148
|
61149
|
61150
|
61492
|
61493
|
61555
|
61556
|
61557
|
61558
|
61559
|
61560
|
61561
|
61562
|
61563
|
61564
|
61565
|
61566
|
61567
|
61568
|
61569
|
61570
|
61571
|
61572
|
61573
|
61574
|
61575