Attachment 5980 Details for Bug 5725 – BZ5725 follow-up for comment 48

[patch] BZ5725 follow-up for comment 48

BZ5725-follow-up-for-comment-48.patch (text/plain), 2.46 KB, created by Paul Poulain on 2011-10-19 13:34:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Poulain

Created: 2011-10-19 13:34:05 UTC

Size: 2.46 KB

patch

obsolete

>From 0ba747707d033e23648b80f9125232c3af4b16fc Mon Sep 17 00:00:00 2001
>From: Paul Poulain <paul.poulain@biblibre.com>
>Date: Tue, 18 Oct 2011 18:10:36 +0200
>Subject: [PATCH] BZ5725 follow-up for comment 48
>
>This small follow up:
>  * removes "whole field" in subfield list except when dealing with a field <010 (that has no subfield)
>  * add a missing string resulting in an "undefined" when user choosed 'Create field and subfield' and hit Add button
>  * synch the description after adding with the description in the list box of the 4 options available
>  * fixes indentation a little
>---
> .../prog/en/modules/tools/batchedit.tt             |   24 +++++++++++--------
> 1 files changed, 14 insertions(+), 10 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchedit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchedit.tt
>index 31c84d1..0d5e0df 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchedit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchedit.tt
>@@ -19,15 +19,18 @@
> 		$("#subfieldchoice option").remove();
> 
> 		    var subfield = $('#subfieldchoice');
>-			$("<option>").attr("value", "@")
>-                                 .text( _('Whole field'))
>-                                 .appendTo('#subfieldchoice');
>+            if (data.length >0)  {
>                 for( var i=0; i < data.length ; i++){
>-			$("<option>").attr("value", data[i].subfield)
>-                                 .text(data[i].subfield)
>-                                 .appendTo('#subfieldchoice');
>+                    $("<option>").attr("value", data[i].subfield)
>+                         .text(data[i].subfield)
>+                         .appendTo('#subfieldchoice');
>                 }
>-                subfieldChanged();
>+            } else {
>+                $("<option>").attr("value", "@")
>+                     .text( _('Whole field'))
>+                     .appendTo('#subfieldchoice');
>+            }
>+            subfieldChanged();
>             }
>         });
>      }
>@@ -70,9 +73,10 @@
> 
>      function addRule(){
>         var actionlabel = {
>-                mod: _('Modify'),
>-                del: _('Delete'),
>-                add: _('Create')
>+                mod: _('Modify subfield'),
>+                del: _('Delete subfield'),
>+                add: _('Create subfield'),
>+                addfield: _('Create field and subfield')
>                 };
>         var repvallabel  = $('#repvalchoice :selected').text()  || $("#repvalchoice").val();
> 
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 5725: 3105 | 3108 | 3191 | 3193 | 3234 | 3356 | 4734 | 4735 | 4736 | 4863 | 4864 | 4897 | 4898 | 4899 | 5404 | 5405 | 5684 | 5685 | 5697 | 5959 | 5960 | 5980 | 5981 | 5982 | 10610 | 10611 | 10612 | 11731 | 11732 | 11733