Bugzilla – Attachment 59827 Details for
Bug 14764
Add OPAC News branch selector
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14764 - [followup] Addressing QA concerns
Bug-14764---followup-Addressing-QA-concerns.patch (text/plain), 3.97 KB, created by
Liz Rea
on 2017-02-02 21:35:56 UTC
(
hide
)
Description:
Bug 14764 - [followup] Addressing QA concerns
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2017-02-02 21:35:56 UTC
Size:
3.97 KB
patch
obsolete
>From 62a4689177556387b9713fd4fdcfa6c6edc48c87 Mon Sep 17 00:00:00 2001 >From: Liz Rea <liz@catalyst.net.nz> >Date: Fri, 3 Feb 2017 10:18:51 +1300 >Subject: [PATCH] Bug 14764 - [followup] Addressing QA concerns > >* removed Policy: >* put the syspref in alpha order with the others >* added els to the if. >--- > installer/data/mysql/sysprefs.sql | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 1 - > opac/opac-main.pl | 2 +- > 3 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 81cae21..ba216a0 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -287,7 +287,6 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('OAI-PMH:MaxCount','50',NULL,'OAI-PMH maximum number of records by answer to ListRecords and ListIdentifiers queries','Integer'), > ('OCLCAffiliateID','','','Use with FRBRizeEditions and XISBN. You can sign up for an AffiliateID here: http://www.worldcat.org/wcpa/do/AffiliateUserServices?method=initSelfRegister','free'), > ('OPACAcquisitionDetails','0','','Show the acquisition details at the OPAC','YesNo'), >-('OpacNewsLibrarySelect','0','','Show selector for branches on OPAC news page','YesNo'), > ('OpacAddMastheadLibraryPulldown','0','','Adds a pulldown menu to select the library to search on the opac masthead.','YesNo'), > ('OpacAdvSearchMoreOptions','pubdate,itemtype,language,subtype,sorting,location','Show search options for the expanded view (More options)','pubdate|itemtype|language|subtype|sorting|location','multiple'), > ('OpacAdvSearchOptions','pubdate,itemtype,language,sorting,location','Show search options','pubdate|itemtype|language|subtype|sorting|location','multiple'), >@@ -340,6 +339,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('OpacNav','Important links here.','70|10','Use HTML tags to add navigational links to the left-hand navigational bar in OPAC','Textarea'), > ('OpacNavBottom','Important links here.','70|10','Use HTML tags to add navigational links to the left-hand navigational bar in OPAC','Textarea'), > ('OpacNavRight','','70|10','Show the following HTML in the right hand column of the main page under the main login form','Textarea'), >+('OpacNewsLibrarySelect','0','','Show selector for branches on OPAC news page','YesNo'), > ('OPACNoResultsFound','','70|10','Display this HTML when no results are found for a search in the OPAC','Textarea'), > ('OPACNumbersPreferPhrase','0',NULL,'Control the use of phr operator in callnumber and standard number OPAC searches','YesNo'), > ('OPACnumSearchResults','20',NULL,'Specify the maximum number of results to display on a page of results','Integer'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >index ea367c8..10674c8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >@@ -509,7 +509,6 @@ OPAC: > yes: Display > no: Don't display > - a branch selection list for news items in the OPAC. >- Policy: > - > - "Use the following as the OPAC ISBD template:" > - pref: OPACISBD >diff --git a/opac/opac-main.pl b/opac/opac-main.pl >index 421eb9c..2f1f18c 100755 >--- a/opac/opac-main.pl >+++ b/opac/opac-main.pl >@@ -54,7 +54,7 @@ if (C4::Context->userenv) { > if (defined $input->param('branch') and length $input->param('branch')) { > $homebranch = $input->param('branch'); > } >-if (C4::Context->userenv and defined $input->param('branch') and length $input->param('branch') == 0 ){ >+elsif (C4::Context->userenv and defined $input->param('branch') and length $input->param('branch') == 0 ){ > $homebranch = ""; > } > my $all_koha_news = &GetNewsToDisplay($news_lang,$homebranch); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14764
:
42129
|
42130
|
42131
|
42132
|
42139
|
42146
|
42147
|
55679
|
55680
|
55681
|
55682
|
55724
|
55725
|
55726
|
56107
|
56108
|
56109
|
57058
|
57059
|
57060
|
57061
|
57062
|
57063
|
57110
|
59648
|
59653
|
59827
|
60396
|
60424
|
60425
|
60451
|
60452