Bugzilla – Attachment 59861 Details for
Bug 17960
Rename opac_news.new with opac_news.content
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17960: Add a test to highlight the issue
Bug-17960-Add-a-test-to-highlight-the-issue.patch (text/plain), 1.43 KB, created by
Nick Clemens (kidclamp)
on 2017-02-03 10:31:54 UTC
(
hide
)
Description:
Bug 17960: Add a test to highlight the issue
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-02-03 10:31:54 UTC
Size:
1.43 KB
patch
obsolete
>From 04af73baabf2f626ff67d8b87b22d3201f368cb7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sat, 21 Jan 2017 10:49:40 +0100 >Subject: [PATCH] Bug 17960: Add a test to highlight the issue > >With only this patch applied, proving t/db_dependent/Koha/News.t >will return > "Attempt to bless into a reference at /home/vagrant/kohaclone/Koha/Object.pm line 78." > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/Koha/News.t | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/News.t b/t/db_dependent/Koha/News.t >index 8061bde..09095b4 100644 >--- a/t/db_dependent/Koha/News.t >+++ b/t/db_dependent/Koha/News.t >@@ -19,7 +19,7 @@ > > use Modern::Perl; > >-use Test::More tests => 4; >+use Test::More tests => 5; > > use Koha::NewsItem; > use Koha::News; >@@ -47,6 +47,7 @@ is( Koha::News->search->count, $nb_of_news + 2, 'The 2 news should have been add > > my $retrieved_news_item_1 = Koha::News->find( $new_news_item_1->idnew ); > is( $retrieved_news_item_1->title, $new_news_item_1->title, 'Find a news_item by id should return the correct news_item' ); >+is( $retrieved_news_item_1->new, $new_news_item_1->new, 'This test is failing because ->new is not a valid accessor'); > > $retrieved_news_item_1->delete; > is( Koha::News->search->count, $nb_of_news + 1, 'Delete should have deleted the news_item' ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17960
:
59406
|
59407
|
59408
|
59409
|
59488
|
59768
|
59772
|
59773
|
59774
|
59775
|
59776
|
59777
| 59861 |
59862
|
59863
|
59864
|
59865
|
59866