Bugzilla – Attachment 59867 Details for
Bug 16984
Standing orders - when ordering a JS error is raised
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16984: Do not clone the item block for standing orders
Bug-16984-Do-not-clone-the-item-block-for-standing.patch (text/plain), 1.51 KB, created by
Nick Clemens (kidclamp)
on 2017-02-03 10:43:32 UTC
(
hide
)
Description:
Bug 16984: Do not clone the item block for standing orders
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-02-03 10:43:32 UTC
Size:
1.51 KB
patch
obsolete
>From 115f3b5dd89a9e72637e930f04a7dc8c5a3eaa86 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 22 Nov 2016 09:35:07 +0000 >Subject: [PATCH] Bug 16984: Do not clone the item block for standing orders > >If AcqCreateItem is set to ordering and the basket is marked as >"standing orders", when ordering a JS error is raised: >additem.js:176 Uncaught TypeError: window[events[i]] is not a function > >The item block should not be displayed in that case. > >Test plan: >- Set AcqCreateItem to "ordering" >- Create a basket and tick the "Standing orders" checkbox >- Add an order to this basket >=> Without this patch you get the JS error >=> With this patch applied you will not get it > >Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >index 45c2852..7feb3d9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >@@ -97,7 +97,7 @@ function Check(ff) { > > $(document).ready(function() > { >- [% IF (AcqCreateItemOrdering) %] >+ [% IF AcqCreateItemOrdering and not basket.is_standing %] > cloneItemBlock(0, '[% UniqueItemFields %]'); > [% END %] > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16984
:
57695
|
58704
| 59867