Bugzilla – Attachment 59877 Details for
Bug 17737
Move GetReservesFromItemnumber to Koha::Item->holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17737: Remove C4::Reserves::GetReservesFromItemnumber
Bug-17737-Remove-C4ReservesGetReservesFromItemnumb.patch (text/plain), 2.15 KB, created by
Marcel de Rooy
on 2017-02-03 12:10:57 UTC
(
hide
)
Description:
Bug 17737: Remove C4::Reserves::GetReservesFromItemnumber
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-02-03 12:10:57 UTC
Size:
2.15 KB
patch
obsolete
>From 94dd0310d445361a094e7a680ae959f21e565c29 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 7 Dec 2016 14:04:17 +0100 >Subject: [PATCH] Bug 17737: Remove C4::Reserves::GetReservesFromItemnumber >Content-Type: text/plain; charset=utf-8 > >At this point, there should not be any occurrences of >GetReservesFromItemnumber anymore. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Reserves.pm | 41 ----------------------------------------- > 1 file changed, 41 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index f1366d9..e304fdd 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -104,7 +104,6 @@ BEGIN { > &AddReserve > > &GetReserve >- &GetReservesFromItemnumber > &GetReservesFromBorrowernumber > &GetReservesForBranch > &GetReservesToBranch >@@ -275,46 +274,6 @@ sub GetReserve { > return $sth->fetchrow_hashref(); > } > >-=head2 GetReservesFromItemnumber >- >- ( $reservedate, $borrowernumber, $branchcode, $reserve_id, $waitingdate ) = GetReservesFromItemnumber($itemnumber); >- >-Get the first reserve for a specific item number (based on priority). Returns the abovementioned values for that reserve. >- >-The routine does not look at future reserves (read: item level holds), but DOES include future waits (a confirmed future hold). >- >-=cut >- >-sub GetReservesFromItemnumber { >- my ($itemnumber) = @_; >- >- my $schema = Koha::Database->new()->schema(); >- >- my $r = $schema->resultset('Reserve')->search( >- { >- itemnumber => $itemnumber, >- suspend => 0, >- -or => [ >- reservedate => \'<= CAST( NOW() AS DATE )', >- waitingdate => { '!=', undef } >- ] >- }, >- { >- order_by => 'priority', >- } >- )->first(); >- >- return unless $r; >- >- return ( >- $r->reservedate(), >- $r->get_column('borrowernumber'), >- $r->get_column('branchcode'), >- $r->reserve_id(), >- $r->waitingdate(), >- ); >-} >- > =head2 GetReservesFromBorrowernumber > > $borrowerreserv = GetReservesFromBorrowernumber($borrowernumber,$tatus); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17737
:
58018
|
58019
|
58673
|
58674
|
58675
|
59872
|
59876
|
59877
|
59878
|
59879
|
62105
|
62106
|
62107
|
62108