Bugzilla – Attachment 5991 Details for
Bug 6553
Parentheses in corporate author break tracings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 6553: parentheses in authors break tracings
SIGNED-OFF-Bug-6553-parentheses-in-authors-break-t.patch (text/plain), 4.08 KB, created by
Katrin Fischer
on 2011-10-19 18:44:10 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 6553: parentheses in authors break tracings
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2011-10-19 18:44:10 UTC
Size:
4.08 KB
patch
obsolete
>From dd833a505e4995e3f740f820f5cd66c53683e594 Mon Sep 17 00:00:00 2001 >From: Ian Walls <ian.walls@bywatersolutions.com> >Date: Mon, 3 Oct 2011 11:22:30 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 6553: parentheses in authors break tracings > >If an author's name includes parentheses or other escape-characters, the tracing links >produced in the OPAC and staff client fail in XSLT mode. This patch wraps the author names >in double-quotes, providing the necessary escapement. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Test plan: >- Create a new framework, delete Thesaurus from 700 and other fields >- Create a new record in this framework >- Add 700$a - use parentheses >- Check the search links in OPAC and staff detail pages >> before patch link was broken, after it works > >Note: Links are only broken when no authorities are being used. >When using authorities the link uses the auth number instead of the text >for linking, so the parentheses don't matter for search. >--- > .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 2 +- > .../prog/en/xslt/MARC21slim2OPACDetail.xsl | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >index 93ae4b4..b0de609 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >@@ -847,7 +847,7 @@ > <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=an:<xsl:value-of select="marc:subfield[@code=9]"/></xsl:attribute> > </xsl:when> > <xsl:otherwise> >- <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=au:<xsl:value-of select="marc:subfield[@code='a']"/></xsl:attribute> >+ <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=au:"<xsl:value-of select="marc:subfield[@code='a']"/>"</xsl:attribute> > </xsl:otherwise> > </xsl:choose> > <xsl:choose> >diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >index 2e4228f..e16db73 100755 >--- a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >@@ -137,7 +137,7 @@ > <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=an:<xsl:value-of select="marc:subfield[@code=9]"/></xsl:attribute> > </xsl:when> > <xsl:otherwise> >- <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=au:<xsl:value-of select="marc:subfield[@code='a']"/></xsl:attribute> >+ <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=au:"<xsl:value-of select="marc:subfield[@code='a']"/>"</xsl:attribute> > </xsl:otherwise> > </xsl:choose> > <xsl:call-template name="nameABCDQ"/></a> >@@ -152,7 +152,7 @@ > <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=an:<xsl:value-of select="marc:subfield[@code=9]"/></xsl:attribute> > </xsl:when> > <xsl:otherwise> >- <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=au:<xsl:value-of select="marc:subfield[@code='a']"/></xsl:attribute> >+ <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=au:"<xsl:value-of select="marc:subfield[@code='a']"/>"</xsl:attribute> > </xsl:otherwise> > </xsl:choose> > <xsl:call-template name="nameABCDN"/></a> >@@ -174,7 +174,7 @@ > <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=an:<xsl:value-of select="marc:subfield[@code=9]"/></xsl:attribute> > </xsl:when> > <xsl:otherwise> >- <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=au:<xsl:value-of select="marc:subfield[@code='a']"/></xsl:attribute> >+ <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=au:"<xsl:value-of select="marc:subfield[@code='a']"/>"</xsl:attribute> > </xsl:otherwise> > </xsl:choose> > <xsl:call-template name="nameACDEQ"/></a> >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6553
:
4788
|
4789
|
5680
|
5991
|
18055
|
18445
|
19303