Attachment 59913 Details for Bug 18044 – Bug 18044: Label Batches not displaying

[patch] Bug 18044: Label Batches not displaying

Bug-18044-Label-Batches-not-displaying.patch (text/plain), 1.13 KB, created by Jonathan Druart on 2017-02-06 08:19:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-02-06 08:19:44 UTC

Size: 1.13 KB

patch

obsolete

>From 0019e5e77b38f347c8c1210aa249bd7f666be824 Mon Sep 17 00:00:00 2001
>From: Chris Nighswonger <cnighswonger@foundations.edu>
>Date: Sun, 5 Feb 2017 16:11:30 -0500
>Subject: [PATCH] Bug 18044: Label Batches not displaying
>
>SQL expects lists to be comma separated. A trailing comma must also
>be avoided.
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> C4/Creators/Lib.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Creators/Lib.pm b/C4/Creators/Lib.pm
>index c15b3e7..eb97bc1 100644
>--- a/C4/Creators/Lib.pm
>+++ b/C4/Creators/Lib.pm
>@@ -151,7 +151,7 @@ sub _build_query {
>         $query .= ' WHERE 1 ';
>         while ( my ( $field, $values ) = each %{ $params->{filters} } ) {
>             if ( ref( $values ) ) {
>-                $query .= " AND $field IN ( " . ( ('?') x scalar( @$values ) ) . " ) ";
>+                $query .= " AND $field IN ( " . ( ('?,') x (@$values-1) ) . "? ) "; # a comma separates elements in a list...
>                 push @where_args, @$values;
>             } else {
>                 $query .= " AND $field = ? ";
>-- 
>2.9.3

Actions: View | Diff | Splinter Review

Attachments on bug 18044: 59909 | 59912 | 59913 | 59914