Attachment 59952 Details for Bug 14608 – Bug 14608: Follow up on labels and search box

[patch] Bug 14608: Follow up on labels and search box

Bug-14608-Follow-up-on-labels-and-search-box.patch (text/plain), 4.32 KB, created by Chris Cormack on 2017-02-06 21:23:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2017-02-06 21:23:47 UTC

Size: 4.32 KB

patch

obsolete

>From fae3eb876f4a1f253d7ca164c6f15ed16e60a2cf Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Fri, 13 Jan 2017 13:33:05 -0500
>Subject: [PATCH] Bug 14608: Follow up on labels and search box
>
>This addresses concerns raised in comment #26 and comment #27.
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> .../prog/en/modules/admin/usage_statistics.tt      | 26 +++++++++++-----------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/usage_statistics.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/usage_statistics.tt
>index 4b943eabf8..5da2693e6c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/usage_statistics.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/usage_statistics.tt
>@@ -9,7 +9,7 @@
> 
> <body id="admin_usage_statistics" class="admin">
> [% INCLUDE 'header.inc' %]
>-[% INCLUDE 'patrons-admin-search.inc' %]
>+[% INCLUDE 'cat-search.inc' %]
> 
> <div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> &rsaquo; Usage statistics</div>
> 
>@@ -50,8 +50,8 @@
>         <fieldset class="rows">
>             <ol>
>                 <li>
>-                    <span class="label">Share my Koha usage statistics: </span>
>-                    <select name="UsageStats">
>+                    <label for="UsageStats">Share my Koha usage statistics: </label>
>+                    <select name="UsageStats" id="UsageStats">
>                     [% IF Koha.Preference('UsageStats') %]
>                         <option value="1" selected="selected">Yes</option>
>                         <option value="0">No</option>
>@@ -62,14 +62,14 @@
>                     </select>
>                 </li>
>                 <li>
>-                    <span class="label">Your country: </span>
>+                    <label for="UsageStatsCountry">Your country: </label>
>                     [% SET UsageStatsCountry = Koha.Preference('UsageStatsCountry') %]
>                     [% SET IsUsageStatsCountryValid = 0 %]
>                     [% IF NOT UsageStatsCountry %]
>                         [% SET IsUsageStatsCountryValid = 1 %]
>                     [% END %]
>-                    <select name="UsageStatsCountry">
>-                        <option value=""></option>
>+                    <select name="UsageStatsCountry" id="UsageStatsCountry">
>+                        <option value="">&nbsp;</option>
>                         [% FOR country IN [
> "Afghanistan",
> "Albania",
>@@ -280,14 +280,14 @@
>                     [% END %]
>                 </li>
>                 <li>
>-                    <span class="label">Library name: </span>
>-                    <input type="text" value="[% Koha.Preference('UsageStatsLibraryName') %]" name="UsageStatsLibraryName" />
>+                    <label for="UsageStatsLibraryName">Library name: </label>
>+                    <input type="text" value="[% Koha.Preference('UsageStatsLibraryName') %]" name="UsageStatsLibraryName" id="UsageStatsLibraryName" />
>                 </li>
>                 <li>
>-                    <span class="label">Library type: </span>
>+                    <label for="UsageStatsLibraryType">Library type: </label>
>                     [% SET UsageStatsLibraryType = Koha.Preference('UsageStatsLibraryType') %]
>-                    <select name="UsageStatsLibraryType">
>-                        <option value=""></option>
>+                    <select name="UsageStatsLibraryType" id="UsageStatsLibraryType">
>+                        <option value="">&nbsp;</option>
>                         [% IF UsageStatsLibraryType == 'public' %]
>                             <option value="public" selected="selected">Public</option>
>                         [% ELSE %]
>@@ -342,8 +342,8 @@
>                     </select>
>                 </li>
>                 <li>
>-                    <span class="label">Library URL: </span>
>-                    <input type="text" name="UsageStatsLibraryUrl" value="[% Koha.Preference('UsageStatsLibraryUrl') %]" />
>+                    <label for="UsageStatsLibraryUrl">Library URL: </label>
>+                    <input type="text" name="UsageStatsLibraryUrl" value="[% Koha.Preference('UsageStatsLibraryUrl') %]" id="UsageStatsLibraryUrl" />
>                 </li>
>                 <li>
>                     <span class="label">Last update: </span>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 14608: 41212 | 41213 | 41712 | 41713 | 55773 | 58340 | 58341 | 58342 | 58968 | 58969 | 58970 | 58971 | 59949 | 59950 | 59951 | 59952 | 61031 | 61201 | 61202 | 61203 | 61204 | 61205