Attachment 6000 Details for Bug 7069 – [SIGNED-OFF] Bug 7069: Put strings in "" instead of '' to fix the javascript not working when the translated string has a ' in it.

[patch] [SIGNED-OFF] Bug 7069: Put strings in "" instead of '' to fix the javascript not working when the translated string has a ' in it.

SIGNED-OFF-Bug-7069-Put-strings-in--instead-of--to.patch (text/plain), 1.99 KB, created by Katrin Fischer on 2011-10-19 20:20:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2011-10-19 20:20:36 UTC

Size: 1.99 KB

patch

obsolete

>From 90630ddca8fbe27e4197ed533ac62d60ba63cee8 Mon Sep 17 00:00:00 2001
>From: Maxime Pelletier <maxime.pelletier@libeo.com>
>Date: Wed, 19 Oct 2011 15:28:16 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 7069: Put strings in "" instead of '' to
> fix the javascript not working when the translated string
> has a ' in it.
>
>http://bugs.koha-community.org/show_bug.cgi?id=7069
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Patch changes '' to "" to make it work for strings which contain '.
>Patch does NOT add new strings to the po files.
>---
> .../intranet-tmpl/prog/en/modules/tags/review.tt   |   10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
>index 5dfe91a..5d025af 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
>@@ -51,22 +51,22 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; }
> 		// window.alert(_('AJAX approved tag: ') + tag);
> 	};
> 	var failure_approve = function(tag){
>-		window.alert(_('AJAX failed to approve tag: ') + tag);
>+		window.alert(_("AJAX failed to approve tag: ") + tag);
> 	};
> 	var success_reject  = function(tag){
> 		// window.alert(_('AJAX rejected tag: ') + tag);
> 	};
> 	var failure_reject  = function(tag){
>-		window.alert(_('AJAX failed to reject tag: ') + tag);
>+		window.alert(_("AJAX failed to reject tag: ") + tag);
> 	};
> 	var success_test    = function(tag){
>-		$('#verdict').html(tag + _(' is permitted!'));
>+		$('#verdict').html(tag + _(" is permitted!"));
> 	};
> 	var failure_test    = function(tag){
>-		$('#verdict').html(tag + _(' is prohibited!'));
>+		$('#verdict').html(tag + _(" is prohibited!"));
> 	};
> 	var indeterminate_test = function(tag){
>-		$('#verdict').html(tag + _(' is neither permitted nor prohibited!'));
>+		$('#verdict').html(tag + _(" is neither permitted nor prohibited!"));
> 	};
> 
> 	var success_test_call = function() {
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 7069: 5992 | 6000 | 6021