Attachment 60016 Details for Bug 7534 – Bug 7534: Add configuration to admin/branches.pl

[patch] Bug 7534: Add configuration to admin/branches.pl

Bug-7534-Add-configuration-to-adminbranchespl.patch (text/plain), 3.26 KB, created by Lari Taskula on 2017-02-08 14:52:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lari Taskula

Created: 2017-02-08 14:52:26 UTC

Size: 3.26 KB

patch

obsolete

>From 40166f606af6f33ae1512f349f7dab8cb742d6ba Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@jns.fi>
>Date: Tue, 7 Feb 2017 19:52:15 +0200
>Subject: [PATCH] Bug 7534: Add configuration to admin/branches.pl
>
>This patch adds a configuration option for pickup locations.
>
>To test:
>1. Apply patch
>2. Go to cgi-bin/koha/admin/branches.pl
>3. Observe there is a new column "Pickup location"
>4. Click "Edit" for any library
>5. Scroll to bottom of the page and select "No"
>6. Click "Submit"
>7. Observe your library in Libraries-table, notice the value of "Pickup location"
>   has changed to "No"
>---
> admin/branches.pl                                         | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 3 +++
> 2 files changed, 4 insertions(+)
>
>diff --git a/admin/branches.pl b/admin/branches.pl
>index abe3e5a..34dde0d 100755
>--- a/admin/branches.pl
>+++ b/admin/branches.pl
>@@ -76,6 +76,7 @@ if ( $op eq 'add_form' ) {
>       branchip
>       branchnotes
>       opac_info
>+      pickup_location
>     );
>     my $is_a_modif = $input->param('is_a_modif');
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>index 5c1f98f..0af5e3d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>@@ -192,6 +192,7 @@ tinyMCE.init({
>                 <li><label for="opac_info">OPAC info: </label><textarea name="opac_info" id="opac_info">[% library.opac_info |html %]</textarea></li>
>                 <li><label for="branchip">IP: </label><input type="text" name="branchip" id="branchip"  size="15" maxlength="15" value="[% library.branchip |html %]" /> <span class="hint">Can be entered as a single IP, or a subnet such as 192.168.1.*</span></li>
>                 <li><label for="branchnotes">Notes: </label><input type="text" name="branchnotes" id="branchnotes" size="80" value="[% library.branchnotes |html %]" /></li>
>+                <li><label for="pickup_location">Pickup location: </label><select name="pickup_location" id="pickup_location"><option value="1" [% IF library.pickup_location %]selected[% END %]>Yes</option><option value="0" [% IF !library.pickup_location %]selected[% END %]>No</option></select></li>
>             </ol>
>         </fieldset>
>         <fieldset class="action">
>@@ -227,6 +228,7 @@ tinyMCE.init({
>                     <th>Address</th>
>                     <th>Properties</th>
>                     <th>IP</th>
>+                    <th>Pickup location</th>
>                     <th>Actions</th>
>                 </tr>
>             </thead>
>@@ -268,6 +270,7 @@ tinyMCE.init({
>                             [% END %]
>                         </td>
>                         <td>[% library.branchip %]</td>
>+                        <td>[% IF library.pickup_location %]Yes[% ELSE %]No[% END %]</td>
>                         <td class="actions">
>                             <a class="btn btn-default btn-xs" href="/cgi-bin/koha/admin/branches.pl?op=add_form&amp;branchcode=[% library.branchcode %]"><i class="fa fa-pencil"></i> Edit</a>
>                             <a class="btn btn-default btn-xs" href="/cgi-bin/koha/admin/branches.pl?op=delete_confirm&amp;branchcode=[% library.branchcode %]"><i class="fa fa-trash"></i> Delete</a>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 7534: 60014 | 60015 | 60016 | 60017 | 60018 | 60022 | 60023 | 60781 | 60794 | 60795 | 60796 | 60797 | 60798 | 60799 | 60878 | 60879 | 60880 | 60881 | 60882 | 60883 | 61044 | 61045 | 61046 | 61047 | 61273 | 61274 | 61275 | 61276 | 61277 | 61278 | 61279 | 61280 | 77847 | 77848 | 77849 | 77850 | 77851 | 77852 | 77853 | 77854 | 77855 | 77856 | 78160 | 78161 | 78162 | 78163 | 78164 | 78165 | 78166 | 78167 | 78168 | 78169 | 78170 | 78171 | 78477 | 78478 | 78479 | 78480 | 78481 | 78482 | 78483 | 78484 | 78485 | 78486 | 78487 | 78488 | 78489 | 78495 | 78540 | 78548 | 84852