Bugzilla – Attachment 60056 Details for
Bug 18089
All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch
Bug-18089---All-XSLT-testing-singleBranchMode--0-f.patch (text/plain), 1.10 KB, created by
Kyle M Hall (khall)
on 2017-02-09 11:49:34 UTC
(
hide
)
Description:
Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has only 1 branch
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2017-02-09 11:49:34 UTC
Size:
1.10 KB
patch
obsolete
>From 902a18e29dba53d243305f7bc04393fdf921b8c3 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 9 Feb 2017 11:48:40 +0000 >Subject: [PATCH] Bug 18089 - All XSLT testing singleBranchMode = 0 fails to > show even if install has only 1 branch > >Due to the way it has been implemented, singleBranchMode is set to an >empty string rather than 0 if there is only one branch. This causes any >block that tests for singleBranchMOde to be 0 to never appear. > >Test Plan: >1) Apply this patch set >2) prove t/XSLT.t >--- > C4/XSLT.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/XSLT.pm b/C4/XSLT.pm >index a829402..b757f8f 100644 >--- a/C4/XSLT.pm >+++ b/C4/XSLT.pm >@@ -179,7 +179,7 @@ sub get_xslt_sysprefs { > > # singleBranchMode was a system preference, but no longer is > # we can retain it here for compatibility >- my $singleBranchMode = Koha::Libraries->search->count == 1; >+ my $singleBranchMode = Koha::Libraries->search->count == 1 ? 1 : 0; > $sysxml .= "<syspref name=\"singleBranchMode\">$singleBranchMode</syspref>\n"; > > $sysxml .= "</sysprefs>\n"; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18089
:
60055
|
60056
|
60059
|
60060
|
60061
|
60062
|
60065
|
60066
|
60067