Attachment 60145 Details for Bug 7614 – Bug 7614: Build a list of pickup locations in OPAC considering transfer limits

[patch] Bug 7614: Build a list of pickup locations in OPAC considering transfer limits

Bug-7614-Build-a-list-of-pickup-locations-in-OPAC-.patch (text/plain), 3.93 KB, created by Lari Taskula on 2017-02-13 11:22:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lari Taskula

Created: 2017-02-13 11:22:13 UTC

Size: 3.93 KB

patch

obsolete

>From dc7d0e527c9f754980f75cf281b95f8275fa9ec4 Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@jns.fi>
>Date: Fri, 10 Feb 2017 17:10:49 +0200
>Subject: [PATCH] Bug 7614: Build a list of pickup locations in OPAC
> considering transfer limits
>
>This patch enables the checks for transfer limits for given biblionumber in
>OPAC when patron proceeds to place a hold. In case none of the items of that
>biblio can be transferred to a library, that library will not be included in
>the list of pickup locations.
>
>To test:
>1. Make sure you meet the following requirements:
>   1.1: You are able to make holds in OPAC
>   1.2: System preference UseBranchTransferLimits set to "Enforce"
>   1.3: System preference BranchTransferLimitsType set to "item type"
>        (for the sake of simplicity of this test plan, but you may also
>         set it to "collection code" and deal with ccodes instead)
>   1.4: System preference item-level_itypes set to "specific item"
>   1.5: You have the default libraries and item types, otherwise replace
>        the branchcodes and itemtypes in this test plan with your own
>2. Make sure 'Fairfield' in cgi-bin/koha/admin/branches.pl has not disabled
>   its ability to act as a "Pickup location"
>3. Have a biblio with exactly one item of item-level itemtype 'BK'
>4. Set item holdingbranch as 'CPL'
>5. Go to cgi-bin/koha/admin/branch_transfer_limits.pl (keep this page open in
>   a second tab for faster testing)
>6. Select library 'Centerville'
>7. Uncheck the checkbox 'FFL - Fairfield' and click Save
>8. Go to OPAC and find your biblio, and start placing a hold on it
>9. Click at the list of "Pick up location"s.
>10. Observe that it is missing 'Fairfield'
>11. Go back to cgi-bin/koha/admin/branch_transfer_limits.pl
>12. Repeat step 6 and this time, check the checkbox 'FFL - Fairfield'
>13. Refresh the page you arrived at step 8
>14. Observe that it now includes 'Fairfield'
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>index 60cbd6e..7c3aea7 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>@@ -215,11 +215,11 @@
>                                                                 <label for="branch_[% bibitemloo.biblionumber %]">Pick up location:</label>
>                                                                 [% UNLESS ( bibitemloo.holdable ) %]
>                                                                     <select name="branch" id="branch_[% bibitemloo.biblionumber %]" disabled="disabled">
>-                                                                        [% PROCESS options_for_libraries libraries => Branches.pickup_locations( selected => branch ) %]
>+                                                                        [% PROCESS options_for_libraries libraries => Branches.pickup_locations( biblio => bibitemloo.biblionumber, selected => branch ) %]
>                                                                     </select>
>                                                                 [% ELSE %]
>                                                                     <select name="branch" id="branch_[% bibitemloo.biblionumber %]">
>-                                                                        [% PROCESS options_for_libraries libraries => Branches.pickup_locations( selected => branch ) %]
>+                                                                        [% PROCESS options_for_libraries libraries => Branches.pickup_locations( biblio => bibitemloo.biblionumber, selected => branch ) %]
>                                                                     </select>
>                                                                 [% END # / UNLESS bibitemloo.holdable %]
>                                                             </li>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 7614: 60141 | 60142 | 60143 | 60144 | 60145 | 60785 | 60786 | 60787 | 60938 | 60946 | 70047 | 77895 | 77896 | 77897 | 77898 | 77899 | 77900 | 78020 | 84295 | 84296 | 84297 | 84298 | 84299 | 84300 | 84301 | 84302 | 84303 | 84304 | 84305 | 84306 | 84307 | 84308 | 84309 | 84310 | 84311