Bugzilla – Attachment 60328 Details for
Bug 17974
Add the Koha::Item->biblio method
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17974 (QA Followup)
Bug-17974-QA-Followup.patch (text/plain), 892 bytes, created by
Nick Clemens (kidclamp)
on 2017-02-16 11:08:20 UTC
(
hide
)
Description:
Bug 17974 (QA Followup)
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-02-16 11:08:20 UTC
Size:
892 bytes
patch
obsolete
>From bc5f8472efe451dcb9a14f23289128c542e34497 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 16 Feb 2017 11:04:11 +0000 >Subject: [PATCH] Bug 17974 (QA Followup) > > Use the $biblio_rs variable > > In case of Koha::Object you can call new_from_dbic directly, however, > it fails for Koha::Objects so using an intermediary variable should > be done for consistency >--- > Koha/Item.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index da3d11a..34bda38 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -88,7 +88,7 @@ Return the bibliographic record of this item > sub biblio { > my ( $self ) = @_; > my $biblio_rs = $self->_result->biblio; >- return Koha::Biblio->_new_from_dbic( $self->_result->biblio ); >+ return Koha::Biblio->_new_from_dbic( $biblio_rs ); > } > > =head3 get_transfer >-- >2.1.4
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=60328">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17974
:
59441
|
59464
|
60327
| 60328