Bugzilla – Attachment 60404 Details for
Bug 17964
TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17964: Add old_issues
Bug-17964-Add-oldissues.patch (text/plain), 2.66 KB, created by
Kyle M Hall (khall)
on 2017-02-17 11:52:56 UTC
(
hide
)
Description:
Bug 17964: Add old_issues
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2017-02-17 11:52:56 UTC
Size:
2.66 KB
patch
obsolete
>From c0016f8878c06a08ab571cee3368b2341585bb77 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sat, 21 Jan 2017 15:48:57 +0100 >Subject: [PATCH] Bug 17964: Add old_issues > >If it's a CHECKIN, C4::Circulation::SendCirculationAlert set a >"old_issues" key instead of "issues". > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Letters.pm | 6 ++++++ > t/db_dependent/Letters/TemplateToolkit.t | 12 ++++++------ > 2 files changed, 12 insertions(+), 6 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index 9308e4f..ebed363 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -1540,6 +1540,12 @@ sub _get_tt_params { > plural => 'checkouts', > fk => 'itemnumber', > }, >+ old_issues => { >+ module => 'Koha::Old::Checkouts', >+ singular => 'old_checkout', >+ plural => 'old_checkouts', >+ fk => 'itemnumber', >+ }, > borrower_modifications => { > module => 'Koha::Patron::Modifications', > singular => 'patron_modification', >diff --git a/t/db_dependent/Letters/TemplateToolkit.t b/t/db_dependent/Letters/TemplateToolkit.t >index 0ba51f9..810961a 100644 >--- a/t/db_dependent/Letters/TemplateToolkit.t >+++ b/t/db_dependent/Letters/TemplateToolkit.t >@@ -416,13 +416,13 @@ The following items have been checked out: > Thank you for visiting <<branches.branchname>>. > |; > reset_template( { template => $checkout_template, code => $checkout_code, module => 'circulation' } ); >- my $checkin_template = q| >+ my $checkin_template = q[ > The following items have been checkin out: > ---- >-<<biblio.title>> >+<<biblio.title>> was due on <<old_issues.date_due | dateonly>> > ---- > Thank you for visiting <<branches.branchname>>. >-|; >+]; > reset_template( { template => $checkin_template, code => $checkin_code, module => 'circulation' } ); > > C4::Circulation::AddIssue( $patron, $item1->{barcode} ); >@@ -446,13 +446,13 @@ The following items have been checked out: > Thank you for visiting [% branch.branchname %]. > |; > reset_template( { template => $checkout_template, code => $checkout_code, module => 'circulation' } ); >- $checkin_template = q| >+ $checkin_template = q[ > The following items have been checkin out: > ---- >-[% biblio.title %] >+[% biblio.title %] was due on [% old_checkout.date_due | $KohaDates %] > ---- > Thank you for visiting [% branch.branchname %]. >-|; >+]; > reset_template( { template => $checkin_template, code => $checkin_code, module => 'circulation' } ); > > C4::Circulation::AddIssue( $patron, $item1->{barcode} ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17964
:
59436
|
59437
|
59438
|
59540
|
59541
|
59542
|
60403
|
60404
|
60405
|
61595
|
61627
|
62460
|
62461
|
62462
|
62463
|
62464