Bugzilla – Attachment 60434 Details for
Bug 18143
Silence floody MARC framework export
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18143: Silence XML MARC Framework export flood
Bug-18143-Silence-XML-MARC-Framework-export-flood.patch (text/plain), 1.31 KB, created by
Mark Tompsett
on 2017-02-19 00:59:17 UTC
(
hide
)
Description:
Bug 18143: Silence XML MARC Framework export flood
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-02-19 00:59:17 UTC
Size:
1.31 KB
patch
obsolete
>From 9e561463bb2c9b04eb3814cec0544ba696f970f2 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Sat, 18 Feb 2017 19:21:59 -0500 >Subject: [PATCH] Bug 18143: Silence XML MARC Framework export flood > >TEST PLAN >--------- >1) Log in to staff client >2) Click Koha administration >3) Click MARC bibliographic framework >4) export default as xml >5) Read the error log > -- it's floody and export is default framework >6) export another framework as xml >7) Read the error log > -- it's floody and export is the correct framework >8) apply the patch >9) repeat steps 4-7 > -- expected frameworks exported, and no flooding. >10) run koha qa test tools >--- > C4/ImportExportFramework.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/C4/ImportExportFramework.pm b/C4/ImportExportFramework.pm >index bc02cca..f89c768 100644 >--- a/C4/ImportExportFramework.pm >+++ b/C4/ImportExportFramework.pm >@@ -415,6 +415,8 @@ sub _export_table_excel > $data = $hashRef->{$_->{name}}; > if ($_->{type} eq 'Number' && !defined($data)) { > $data = '0'; >+ } elsif ($_->{type} eq 'String' && !defined($data)) { >+ $data = q{}; > } elsif ($_->{type} eq 'String' && (!$data && $data ne '0')) { > $data = '#'; > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18143
:
60434
|
60435
|
83825
|
83826
|
84968
|
84969