Bugzilla – Attachment 6050 Details for
Bug 7085
Problems with searching for orders in acquisitions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-7085-Problems-with-searching-for-orders-.patch (text/plain), 1.79 KB, created by
Owen Leonard
on 2011-10-25 14:20:02 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-10-25 14:20:02 UTC
Size:
1.79 KB
patch
obsolete
>From b8f9093729a3f50c04dcfd2a9013eab8677c68bc Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 25 Oct 2011 10:16:02 -0400 >Subject: [PATCH] Fix for Bug 7085 - Problems with searching for orders in acquisitions >Content-Type: text/plain; charset="utf-8" > >Changing "if ( defined $input )" to "if ( $input )" in the section >of the script which builds the order search query seems to give >successful searches where they didn't exist before. Searches from >the advanced order search screen work with title, author, vendor, >basket number, date, etc. >--- > C4/Acquisition.pm | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 19c4f08..a0dda42 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -1581,33 +1581,33 @@ sub GetHistory { > > my @query_params = (); > >- if ( defined $title ) { >+ if ( $title ) { > $query .= " AND biblio.title LIKE ? "; > $title =~ s/\s+/%/g; > push @query_params, "%$title%"; > } > >- if ( defined $author ) { >+ if ( $author ) { > $query .= " AND biblio.author LIKE ? "; > push @query_params, "%$author%"; > } > >- if ( defined $isbn ) { >+ if ( $isbn ) { > $query .= " AND biblioitems.isbn LIKE ? "; > push @query_params, "%$isbn%"; > } > >- if ( defined $name ) { >+ if ( $name ) { > $query .= " AND aqbooksellers.name LIKE ? "; > push @query_params, "%$name%"; > } > >- if ( defined $from_placed_on ) { >+ if ( $from_placed_on ) { > $query .= " AND creationdate >= ? "; > push @query_params, $from_placed_on; > } > >- if ( defined $to_placed_on ) { >+ if ( $to_placed_on ) { > $query .= " AND creationdate <= ? "; > push @query_params, $to_placed_on; > } >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7085
:
6048
|
6050
|
6113
|
6439