Bugzilla – Attachment 60547 Details for
Bug 18152
UNIMARC bib records imported with invalid 'a' char in label pos.9
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18152 : fix unimarc label in SetMarcUnicodeFlag
Bug-18152--fix-unimarc-label-in-SetMarcUnicodeFlag.patch (text/plain), 1.63 KB, created by
Stéphane Delaune
on 2017-02-22 11:30:05 UTC
(
hide
)
Description:
Bug 18152 : fix unimarc label in SetMarcUnicodeFlag
Filename:
MIME Type:
Creator:
Stéphane Delaune
Created:
2017-02-22 11:30:05 UTC
Size:
1.63 KB
patch
obsolete
>From d10ce5782071d83ff0466896b3365c7c2e2439a1 Mon Sep 17 00:00:00 2001 >From: Koha User <support@biblibre.com> >Date: Wed, 22 Feb 2017 12:25:33 +0100 >Subject: [PATCH] Bug 18152 : fix unimarc label in SetMarcUnicodeFlag > >The standard UNIMARC requires than the 9th character (starting from 0) in >labels must be blank (while it may be 'a' in marc21) > >the problem is that C4::Charset::SetMarcUnicodeFlag (called in particular when >we import a record) always add 'a' char in the 9th label'pos whereas it should >do it just for MARC21 and NORMARC (not for UNIMARC) : > >C4::Charset::SetMarcUnicodeFlag add 'a' char in the 9th label character for >MARC21 and NORMARC (it's normal), but just before doing this it call >"$marc_record->encoding('UTF-8')" which is a MARC::Record function which, when >called with 'UTF-8' parameter, do only one thing : add 'a' char in the 9th >label character > >This patch only removes this incorrect function call, so, when we import a bib >record in UNIMARC : it no longer adds erroneous character (this does not change >anything for MARC21 and NORMARC because SetMarcUnicodeFlag explicitly adds 'a' >char in the 9th label for them) >--- > C4/Charset.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/C4/Charset.pm b/C4/Charset.pm >index 1f2a8c9..817682b 100644 >--- a/C4/Charset.pm >+++ b/C4/Charset.pm >@@ -324,7 +324,6 @@ sub SetMarcUnicodeFlag { > my $marc_record = shift; > my $marc_flavour = shift; # || C4::Context->preference("marcflavour"); > >- $marc_record->encoding('UTF-8'); > if ($marc_flavour eq 'MARC21' || $marc_flavour eq 'NORMARC') { > my $leader = $marc_record->leader(); > substr($leader, 9, 1) = 'a'; >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18152
:
60547
|
60548
|
60549
|
60550
|
60551
|
62246
|
63008
|
63040
|
63041
|
63102
|
63103