Bugzilla – Attachment 60639 Details for
Bug 16202
Rental fees can be generated for fractions of a penny/cent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16202: GetIssuingCharges should return a collectable amount
Bug-16202-GetIssuingCharges-should-return-a-collec.patch (text/plain), 1.90 KB, created by
Jonathan Druart
on 2017-02-24 08:23:54 UTC
(
hide
)
Description:
Bug 16202: GetIssuingCharges should return a collectable amount
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-02-24 08:23:54 UTC
Size:
1.90 KB
patch
obsolete
>From 348b6ac859588c483df305ccd33b68aa93813556 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Tue, 5 Apr 2016 12:56:24 +0100 >Subject: [PATCH] Bug 16202: GetIssuingCharges should return a collectable > amount > >Charges should not include elements less than a penny/cent >they are not displayed but can be saved to the database >causing "odd" behaviour down the line > >Make the routine round the resultant charge to nearest cent, >so consistent values are returned. >Removed the one case where it was rounded post call. >Although the main danger is values generated by the discount >calculation apply the rounding to all returned charges in case >the item charge is defined using the 3rd or 4th decimal >places. > >NOTE: prove -v t/db_dependent/Circulation.t triggers the change. > Though, all the returned amounts are 0.00 only. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Circulation.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index e2cd626..62ad1d9 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -935,7 +935,6 @@ sub CanBookBeIssued { > if ( $rentalConfirmation ){ > my ($rentalCharge) = GetIssuingCharges( $item->{'itemnumber'}, $borrower->{'borrowernumber'} ); > if ( $rentalCharge > 0 ){ >- $rentalCharge = sprintf("%.02f", $rentalCharge); > $needsconfirmation{RENTALCHARGE} = $rentalCharge; > } > } >@@ -3133,6 +3132,9 @@ sub GetIssuingCharges { > my $discount = _get_discount_from_rule($discount_rules, $branch, $item_type); > $charge = ( $charge * ( 100 - $discount ) ) / 100; > } >+ if ($charge) { >+ $charge = sprintf '%.2f', $charge; # ensure no fractions of a penny returned >+ } > } > > return ( $charge, $item_type ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16202
:
49907
|
59741
| 60639