Bugzilla – Attachment 60640 Details for
Bug 18122
Audio alerts: Add hint on where to enable sounds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18122 - Audio alerts: Add hint on where to enable sounds
Bug-18122---Audio-alerts-Add-hint-on-where-to-enab.patch (text/plain), 2.79 KB, created by
Jonathan Druart
on 2017-02-24 08:26:52 UTC
(
hide
)
Description:
Bug 18122 - Audio alerts: Add hint on where to enable sounds
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-02-24 08:26:52 UTC
Size:
2.79 KB
patch
obsolete
>From a5c155180109661a8644acf7b68ebc7a7d01b258 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Wed, 15 Feb 2017 10:24:56 +0100 >Subject: [PATCH] Bug 18122 - Audio alerts: Add hint on where to enable sounds > >This patch adds a hint to page Home > Administration > Audio alerts >and related help page about where to enable the sound system >(syspref 'AudioAlerts'). > >To test: >- Apply patch >- Disable syspref 'AudioAlerts' >- Go to Home > Administration > Audio alerts >- Note hint below title 'Audio alerts' >- Enable syspref 'AudioAlerts' >- Go to Home > Administration > Audio alerts >- Hint is no longer visible (since audios are enabled) >- Open Help page (top right) >- Verify that hint on help page makes sense. > >Amended to add alert class as requested by comment #2 2017-02-21 mv > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt | 7 +++++++ > koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/audio_alerts.tt | 2 ++ > 2 files changed, 9 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt >index 340198e..a1d3309 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt >@@ -1,3 +1,4 @@ >+[% USE Koha %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › Administration › Audio alerts</title> > [% INCLUDE 'doc-head-close.inc' %] >@@ -75,6 +76,12 @@ > > <form id="delete-alert-form" action="audio_alerts.pl" method="post"> > <h3>Audio alerts</h3> >+ [%IF !( Koha.Preference('AudioAlerts') ) %] >+ <div class="dialog alert"> >+ <p><strong>Note: </strong></p> >+ <p>Please enable system preference 'AudioAlerts' to activate sounds.</p> >+ </div> >+ [% END %] > <table id="audio-alerts-table"> > <thead id="audio-alerts-table-head"> > <tr> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/audio_alerts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/audio_alerts.tt >index 01c07d7..5b824cf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/audio_alerts.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/audio_alerts.tt >@@ -4,6 +4,8 @@ > > <p>This section of Koha lets you specify a given sound to play when a given jQuery selector is matched.</p> > >+<p><em>Note: Use system preference 'AudioAlerts' to enable/disable sounds.</em><p> >+ > <h2>Adding a new alert</h2> > > <p>To add a new alert:</p> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18122
:
60246
|
60536
|
60571
| 60640