Attachment 60707 Details for Bug 16966 – Bug 16966: Fix small QA issues

[patch] Bug 16966: Fix small QA issues

Bug-16966-Fix-small-QA-issues.patch (text/plain), 2.01 KB, created by Marcel de Rooy on 2017-02-27 12:46:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-02-27 12:46:02 UTC

Size: 2.01 KB

patch

obsolete

>From d4025bd34210a4a886c947d2334a6547f274a2cb Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 24 Feb 2017 12:25:33 +0100
>Subject: [PATCH] Bug 16966: Fix small QA issues
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Patrons.pm               | 2 +-
> t/db_dependent/Koha/Patrons.t | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Patrons.pm b/Koha/Patrons.pm
>index 8430d16..5571417 100644
>--- a/Koha/Patrons.pm
>+++ b/Koha/Patrons.pm
>@@ -71,7 +71,7 @@ sub search_housebound_deliverers {
>     return Koha::Patrons->_new_from_dbic($del);
> }
> 
>-=head3
>+=head3 search_upcoming_membership_expires
> 
> my $patrons = Koha::Patrons->search_upcoming_membership_expires();
> 
>diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t
>index 04f4565..09a060e 100644
>--- a/t/db_dependent/Koha/Patrons.t
>+++ b/t/db_dependent/Koha/Patrons.t
>@@ -716,8 +716,8 @@ subtest 'search_patrons_to_anonymise & anonymise_issue_history' => sub {
>         my ( $returned, undef, undef ) = C4::Circulation::AddReturn( $item->{barcode}, undef, undef, undef, '2010-10-10' );
>         is( $returned, 1, 'The item should have been returned' );
> 
>-        my $patron_to_anonymise = Koha::Patrons->search_patrons_to_anonymise( '2010-10-11' )->search( { 'me.borrowernumber' => $patron->{borrowernumber} } )->next;
>-        is( ref($patron_to_anonymise), 'Koha::Patron', 'search_patrons_to_anonymise should return Koha::Patrons' );
>+        my $patrons_to_anonymise = Koha::Patrons->search_patrons_to_anonymise( '2010-10-11' )->search( { 'me.borrowernumber' => $patron->{borrowernumber} } );
>+        is( ref($patrons_to_anonymise), 'Koha::Patrons', 'search_patrons_to_anonymise should return Koha::Patrons' );
> 
>         my $rows_affected = Koha::Patrons->search_patrons_to_anonymise( '2010-10-11')->anonymise_issue_history('2010-10-11');
>         ok( $rows_affected > 0, 'AnonymiseIssueHistory should affect at least 1 row' );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16966: 53658 | 53659 | 53660 | 53661 | 56376 | 56377 | 56378 | 56379 | 56639 | 56640 | 56641 | 56642 | 57170 | 57171 | 57172 | 57885 | 57886 | 57887 | 57924 | 57925 | 57926 | 58282 | 58283 | 58284 | 58285 | 58286 | 60377 | 60378 | 60379 | 60380 | 60381 | 60382 | 60648 | 60649 | 60650 | 60651 | 60652 | 60653 | 60701 | 60702 | 60703 | 60704 | 60705 | 60706 | 60707 | 60708 | 60709