Attachment 60714 Details for Bug 18169 – Bug 18169: Add test without before parameter for search_patrons_to_anonymise

[patch] Bug 18169: Add test without before parameter for search_patrons_to_anonymise

Bug-18169-Add-test-without-before-parameter-for-se.patch (text/plain), 2.31 KB, created by Marcel de Rooy on 2017-02-27 13:52:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-02-27 13:52:53 UTC

Size: 2.31 KB

patch

obsolete

>From 9e6f67000b59810fb98d8ea9f69c36ae4d6947a7 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 27 Feb 2017 13:28:20 +0000
>Subject: [PATCH] Bug 18169: Add test without before parameter for
> search_patrons_to_anonymise
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Koha/Patrons.t | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t
>index 7fac24e..24a4a3d 100644
>--- a/t/db_dependent/Koha/Patrons.t
>+++ b/t/db_dependent/Koha/Patrons.t
>@@ -688,7 +688,7 @@ subtest 'search_patrons_to_anonymise & anonymise_issue_history' => sub {
>     t::lib::Mocks::mock_preference( 'AnonymousPatron', $anonymous->{borrowernumber} );
> 
>     subtest 'patron privacy is 1 (default)' => sub {
>-        plan tests => 6;
>+        plan tests => 8;
> 
>         t::lib::Mocks::mock_preference('IndependentBranches', 0);
>         my $patron = $builder->build(
>@@ -753,6 +753,17 @@ subtest 'search_patrons_to_anonymise & anonymise_issue_history' => sub {
>         ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
>         is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue should have been anonymised, the returned date is before' );
> 
>+        my $sth_reset = $dbh->prepare(q|UPDATE old_issues SET borrowernumber = ? WHERE itemnumber = ?|);
>+        $sth_reset->execute( $patron->{borrowernumber}, $item_1->{itemnumber} );
>+        $sth_reset->execute( $patron->{borrowernumber}, $item_2->{itemnumber} );
>+        $rows_affected = Koha::Patrons->search_patrons_to_anonymise->anonymise_issue_history;
>+        $sth->execute($item_1->{itemnumber});
>+        ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
>+        is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue 1 should have been anonymised, before parameter was not passed' );
>+        $sth->execute($item_2->{itemnumber});
>+        ($borrowernumber_used_to_anonymised) = $sth->fetchrow_array;
>+        is( $borrowernumber_used_to_anonymised, $anonymous->{borrowernumber}, 'The issue 2 should have been anonymised, before parameter was not passed' );
>+
>         Koha::Patrons->find( $patron->{borrowernumber})->delete;
>     };
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18169: 60655 | 60712 | 60713 | 60714