Bugzilla – Attachment 60748 Details for
Bug 14576
Allow automatic update of location on checkin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14576 (QA Followup) Fix issue.t
Bug-14576-QA-Followup-Fix-issuet.patch (text/plain), 4.11 KB, created by
Nick Clemens (kidclamp)
on 2017-03-01 02:05:18 UTC
(
hide
)
Description:
Bug 14576 (QA Followup) Fix issue.t
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-03-01 02:05:18 UTC
Size:
4.11 KB
patch
obsolete
>From b60873fc8dc095cf0dae8c6d7b82c9a984d75a84 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 1 Mar 2017 01:29:42 +0000 >Subject: [PATCH] Bug 14576 (QA Followup) Fix issue.t > >--- > t/db_dependent/Circulation/issue.t | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > >diff --git a/t/db_dependent/Circulation/issue.t b/t/db_dependent/Circulation/issue.t >index 519340d..d471d42 100644 >--- a/t/db_dependent/Circulation/issue.t >+++ b/t/db_dependent/Circulation/issue.t >@@ -17,7 +17,6 @@ > > use Modern::Perl; > >-use Test::More tests => 33; > use DateTime::Duration; > > use t::lib::Mocks; >@@ -33,7 +32,7 @@ use Koha::Database; > use Koha::DateUtils; > use Koha::Library; > >-use Test::More tests => 44; >+use Test::More tests => 45; > > BEGIN { > require_ok('C4::Circulation'); >@@ -370,29 +369,29 @@ my $itemnumber2; > { > barcode => 'barcode_4', > itemcallnumber => 'callnumber4', >- homebranch => $samplebranch1->{branchcode}, >- holdingbranch => $samplebranch1->{branchcode}, >+ homebranch => $branchcode_1, >+ holdingbranch => $branchcode_1, > location => 'FIC', > }, > $biblionumber > ); > > t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', q{} ); >-AddReturn( 'barcode_4', $samplebranch1->{branchcode} ); >+AddReturn( 'barcode_4', $branchcode_1 ); > my $item2 = GetItem( $itemnumber2 ); > ok( $item2->{location} eq 'FIC', 'UpdateItemLocationOnCheckin does not modify value when not enabled' ); > > t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', 'FIC: GEN' ); >-AddReturn( 'barcode_4', $samplebranch1->{branchcode} ); >+AddReturn( 'barcode_4', $branchcode_1 ); > $item2 = GetItem( $itemnumber2 ); > ok( $item2->{location} eq 'GEN', q{UpdateItemLocationOnCheckin updates location value from 'FIC' to 'GEN' with setting "FIC: GEN"} ); > ok( $item2->{permanent_location} eq 'GEN', q{UpdateItemLocationOnCheckin updates permanent_location value from 'FIC' to 'GEN' with setting "FIC: GEN"} ); >-AddReturn( 'barcode_4', $samplebranch1->{branchcode} ); >+AddReturn( 'barcode_4', $branchcode_1 ); > $item2 = GetItem( $itemnumber2 ); > ok( $item2->{location} eq 'GEN', q{UpdateItemLocationOnCheckin does not update location value from 'GEN' with setting "FIC: GEN"} ); > > t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', '_ALL_: CART' ); >-AddReturn( 'barcode_4', $samplebranch1->{branchcode} ); >+AddReturn( 'barcode_4', $branchcode_1 ); > $item2 = GetItem( $itemnumber2 ); > ok( $item2->{location} eq 'CART', q{UpdateItemLocationOnCheckin updates location value from 'GEN' with setting "_ALL_: CART"} ); > ok( $item2->{permanent_location} eq 'GEN', q{UpdateItemLocationOnCheckin does not update permanent_location value from 'GEN' with setting "_ALL_: CART"} ); >@@ -401,14 +400,14 @@ $item2 = GetItem( $itemnumber2 ); > ok( $item2->{location} eq 'GEN', q{Location updates from 'CART' to permanent location on issue} ); > > t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', "GEN: _BLANK_\n_BLANK_: PROC\nPROC: _PERM_" ); >-AddReturn( 'barcode_4', $samplebranch1->{branchcode} ); >+AddReturn( 'barcode_4', $branchcode_1 ); > $item2 = GetItem( $itemnumber2 ); > ok( $item2->{location} eq '', q{UpdateItemLocationOnCheckin updates location value from 'GEN' to '' with setting "GEN: _BLANK_"} ); >-AddReturn( 'barcode_4', $samplebranch1->{branchcode} ); >+AddReturn( 'barcode_4', $branchcode_1 ); > $item2 = GetItem( $itemnumber2 ); > ok( $item2->{location} eq 'PROC' , q{UpdateItemLocationOnCheckin updates location value from '' to 'PROC' with setting "_BLANK_: PROC"} ); > ok( $item2->{permanent_location} eq '' , q{UpdateItemLocationOnCheckin does not update permanent_location value from '' to 'PROC' with setting "_BLANK_: PROC"} ); >-AddReturn( 'barcode_4', $samplebranch1->{branchcode} ); >+AddReturn( 'barcode_4', $branchcode_1 ); > $item2 = GetItem( $itemnumber2 ); > ok( $item2->{location} eq '' , q{UpdateItemLocationOnCheckin updates location value from 'PROC' to '' with setting "PROC: _PERM_" } ); > ok( $item2->{permanent_location} eq '' , q{UpdateItemLocationOnCheckin does not update permanent_location from '' with setting "PROC: _PERM_" } ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14576
:
46454
|
46455
|
46456
|
48258
|
48259
|
50662
|
50663
|
52195
|
52196
|
52197
|
52204
|
52205
|
52206
|
52222
|
52223
|
52224
|
52365
|
53112
|
53113
|
53114
|
53115
|
54281
|
54644
|
54645
|
54646
|
54647
|
54648
|
54654
|
55587
|
60658
|
60659
|
60660
|
60661
|
60662
|
60663
|
60747
|
60748
|
60751
|
61940
|
61941
|
61942
|
61944
|
61945
|
61946
|
61947
|
61948
|
61949
|
61950
|
64656
|
64657
|
64658
|
67610
|
67611
|
68297
|
70795
|
70796
|
70797
|
72032
|
72033
|
72034
|
75661
|
75662
|
75663
|
79245
|
79246
|
79995
|
79996
|
83113
|
83114
|
83115
|
83696
|
83697
|
83698
|
85406
|
85850
|
85851
|
85852
|
85853
|
86812
|
86813
|
86814
|
86815
|
86816
|
87040
|
87061
|
87144
|
87145
|
87146
|
87147
|
87148
|
87149
|
87150
|
87151
|
87925
|
88451
|
88452
|
88453
|
88454
|
88455
|
88456
|
88457
|
88458
|
88459
|
88646
|
88647
|
88648
|
88649
|
88650
|
88651
|
88652
|
88653
|
88654