Attachment 60765 Details for Bug 15707 – Bug 15707 [QA Followup] - Allow object names to be styled without impeding translation

[patch] Bug 15707 [QA Followup] - Allow object names to be styled without impeding translation

Bug-15707-QA-Followup---Allow-object-names-to-be-s.patch (text/plain), 3.29 KB, created by Kyle M Hall (khall) on 2017-03-01 14:03:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2017-03-01 14:03:03 UTC

Size: 3.29 KB

patch

obsolete

>From 8bebc0fd7c1a1f7f83fb3d286a11b31ebfff9e40 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 20 Jun 2016 11:45:10 +0000
>Subject: [PATCH] Bug 15707 [QA Followup] - Allow object names to be styled
> without impeding translation
>
>---
> Koha/Template/Plugin/KohaSpan.pm                   | 43 ++++++++++++++++++++++
> .../prog/en/modules/admin/library_groups.tt        |  9 +++--
> 2 files changed, 48 insertions(+), 4 deletions(-)
> create mode 100644 Koha/Template/Plugin/KohaSpan.pm
>
>diff --git a/Koha/Template/Plugin/KohaSpan.pm b/Koha/Template/Plugin/KohaSpan.pm
>new file mode 100644
>index 0000000..6286116
>--- /dev/null
>+++ b/Koha/Template/Plugin/KohaSpan.pm
>@@ -0,0 +1,43 @@
>+package Koha::Template::Plugin::KohaSpan;
>+
>+# Copyright ByWater Solutions 2016
>+# Author: Kyle M Hall <kyle@bywatersolutions.com>
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+
>+use Template::Plugin::Filter;
>+use base qw( Template::Plugin::Filter );
>+
>+our $DYNAMIC = 1;
>+
>+sub filter {
>+    my ( $self, $text, $args, $config ) = @_;
>+
>+    $config->{with_hours} //= 0;
>+    my $id    = $config->{id};
>+    my $class = $config->{class};
>+
>+    my $span = "<span";
>+    $span .= " id='$id'"       if $id;
>+    $span .= " class='$class'" if $class;
>+    $span .= ">$text</span>";
>+
>+    return $span;
>+}
>+
>+1;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
>index f9131ab..0026fc4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt
>@@ -1,3 +1,4 @@
>+[% USE KohaSpan %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Administration &rsaquo; Library groups</title>
> [% INCLUDE 'doc-head-close.inc' %]
>@@ -94,17 +95,17 @@
> [% IF added %]
>     <div class="dialog message group-added">
>         [% IF added.branchcode %]
>-            <i>[% added.library.branchname %]</i> added to group.
>+            [% added.library.branchname | $KohaSpan class = 'name' %] added to group.
>         [% ELSE %]
>-            Group <i>[% added.title %]</i> created.
>+            Group [% added.title | $KohaSpan class = 'name' %] created.
>         [% END %]
>     </div>
> [% ELSIF deleted %]
>     <div class="dialog message group-deleted">
>         [% IF deleted.title %]
>-            Group <i>[% deleted.title %]</i> has been deleted.
>+            Group [% deleted.title | $KohaSpan class = 'name' %] has been deleted.
>         [% ELSE %]
>-            <i>[% deleted.library %]</i> has been removed from group.
>+            [% deleted.library | $KohaSpan class = 'name' %] has been removed from group.
>         [% END %]
>     </div>
> [% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 15707: 47479 | 47480 | 47481 | 47482 | 47483 | 47484 | 47728 | 47729 | 47730 | 47731 | 47732 | 47733 | 47734 | 47849 | 47850 | 47851 | 47852 | 47853 | 47854 | 47855 | 47868 | 47869 | 47870 | 47871 | 47872 | 47873 | 47874 | 48072 | 50400 | 50401 | 50402 | 50403 | 50404 | 50405 | 50406 | 50407 | 50408 | 52267 | 52268 | 52269 | 52270 | 52271 | 52272 | 52273 | 52274 | 52275 | 52367 | 52370 | 52562 | 52563 | 52564 | 52565 | 52566 | 52567 | 52568 | 52569 | 52570 | 52571 | 52572 | 52573 | 52574 | 52575 | 57080 | 57081 | 57082 | 57083 | 57084 | 57085 | 57086 | 57087 | 57088 | 57089 | 57090 | 57091 | 57092 | 57093 | 58086 | 60504 | 60505 | 60506 | 60507 | 60508 | 60509 | 60510 | 60511 | 60512 | 60513 | 60514 | 60515 | 60516 | 60517 | 60518 | 60572 | 60573 | 60574 | 60575 | 60576 | 60577 | 60578 | 60579 | 60580 | 60581 | 60582 | 60583 | 60584 | 60585 | 60586 | 60587 | 60755 | 60756 | 60757 | 60758 | 60759 | 60760 | 60761 | 60762 | 60763 | 60764 | 60765 | 60766 | 60767 | 60768 | 60769 | 60770 | 60771 | 65666 | 65667 | 65668 | 65669 | 65670 | 65671 | 65672 | 65673 | 65674 | 65675 | 65676 | 65677 | 65678 | 65679 | 65680 | 65681 | 69514 | 69515 | 69516 | 69517 | 69518 | 69519 | 69520 | 69521 | 69522 | 69523 | 69524 | 69525 | 69526 | 69527 | 69528 | 69529 | 69573 | 69574 | 69575 | 69576 | 69577 | 69578 | 69579 | 69580 | 69581 | 69582 | 69583 | 69584 | 69585 | 69586 | 69587 | 69588 | 69589