Attachment 60798 Details for Bug 7534 – Bug 7534: Display pickup locations instead of all libraries in opac-reserve.pl

[patch] Bug 7534: Display pickup locations instead of all libraries in opac-reserve.pl

Bug-7534-Display-pickup-locations-instead-of-all-l.patch (text/plain), 2.88 KB, created by Lari Taskula on 2017-03-02 16:09:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lari Taskula

Created: 2017-03-02 16:09:21 UTC

Size: 2.88 KB

patch

obsolete

>From 36e45fd96730415a93e4f00ba39e11b31decd857 Mon Sep 17 00:00:00 2001
>From: Lari Taskula <lari.taskula@jns.fi>
>Date: Tue, 7 Feb 2017 19:42:22 +0200
>Subject: [PATCH] Bug 7534: Display pickup locations instead of all libraries
> in opac-reserve.pl
>
>This patch sets opac-reserve.tt to use the list of pickup libraries instead
>of every library in the system.
>
>To test:
>1. Go to cgi-bin/koha/admin/branches.pl
>2. Configure one of your libraries to "Pickup location" => "No"
>3. Go to OPAC and place a hold
>4. See the provided Pickup location list
>5. Observe the library that you configured is not present in the list
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>index 3c192e0..75d2482 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>@@ -215,12 +215,12 @@
>                                                                 <label for="branch_[% bibitemloo.biblionumber %]">Pick up location:</label>
>                                                                 [% UNLESS ( bibitemloo.holdable ) %]
>                                                                     <select name="branch" id="branch_[% bibitemloo.biblionumber %]" disabled="disabled">
>-                                                                        [% PROCESS options_for_libraries libraries => Branches.all( selected => branch ) %]
>+                                                                        [% PROCESS options_for_libraries libraries => Branches.pickup_locations( selected => branch ) %]
>                                                                     </select>
>                                                                 [% ELSE %]
>                                                                     [% SET at_least_one_library_not_available_for_pickup = 0 %]
>                                                                     <select name="branch" id="branch_[% bibitemloo.biblionumber %]">
>-                                                                        [% FOREACH library IN Branches.all( selected => branch) %]
>+                                                                        [% FOREACH library IN Branches.pickup_locations( selected => branch) %]
>                                                                             [% SET pickup_available_at = bibitemloo.not_available_at.grep(library.branchcode).size ? 0 : 1 %]
>                                                                             [% IF library.selected AND pickup_available_at %]
>                                                                                 <option value="[% library.branchcode %]" selected="selected" >[% library.branchname %]</option>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 7534: 60014 | 60015 | 60016 | 60017 | 60018 | 60022 | 60023 | 60781 | 60794 | 60795 | 60796 | 60797 | 60798 | 60799 | 60878 | 60879 | 60880 | 60881 | 60882 | 60883 | 61044 | 61045 | 61046 | 61047 | 61273 | 61274 | 61275 | 61276 | 61277 | 61278 | 61279 | 61280 | 77847 | 77848 | 77849 | 77850 | 77851 | 77852 | 77853 | 77854 | 77855 | 77856 | 78160 | 78161 | 78162 | 78163 | 78164 | 78165 | 78166 | 78167 | 78168 | 78169 | 78170 | 78171 | 78477 | 78478 | 78479 | 78480 | 78481 | 78482 | 78483 | 78484 | 78485 | 78486 | 78487 | 78488 | 78489 | 78495 | 78540 | 78548 | 84852