Attachment 60844 Details for Bug 18215 – Bug 18215: Resolve warning on $tls in Database.pm

[patch] Bug 18215: Resolve warning on $tls in Database.pm

Bug-18215-Resolve-warning-on-tls-in-Databasepm.patch (text/plain), 1.05 KB, created by Kyle M Hall (khall) on 2017-03-06 13:36:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2017-03-06 13:36:32 UTC

Size: 1.05 KB

patch

obsolete

>From 2b85d50993e7d77aa4f62f3bcbe70c9be32eaec9 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 6 Mar 2017 10:39:18 +0100
>Subject: [PATCH] Bug 18215: Resolve warning on $tls in Database.pm
>
>Resolve this warning:
>updatedatabase.pl: Use of uninitialized value $tls in string eq at /usr/share/koha/masterclone/Koha/Database.pm line 63.
>
>Test plan:
>[1] Check if you do not see the warning anymore.
>
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>Warning disappears after applying the patch.
>---
> Koha/Database.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Database.pm b/Koha/Database.pm
>index c5b2b73..df259c5 100644
>--- a/Koha/Database.pm
>+++ b/Koha/Database.pm
>@@ -60,7 +60,7 @@ sub _new_schema {
>     my $db_passwd = $context->config("pass");
>     my $tls = $context->config("tls");
>     my $tls_options;
>-    if ($tls eq 'yes'){
>+    if( $tls && $tls eq 'yes' ) {
>         my $ca = $context->config('ca');
>         my $cert = $context->config('cert');
>         my $key = $context->config('key');
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18215: 60823 | 60832 | 60844 | 60846 | 60975 | 61005