Bugzilla – Attachment 60845 Details for
Bug 18104
Allow SIP2 field AE (personal name) to be customized
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18104 - allow SIP2 field AE (personal name ) to be customized
Bug-18104---allow-SIP2-field-AE-personal-name--to-.patch (text/plain), 3.32 KB, created by
Kyle M Hall (khall)
on 2017-03-06 14:02:40 UTC
(
hide
)
Description:
Bug 18104 - allow SIP2 field AE (personal name ) to be customized
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2017-03-06 14:02:40 UTC
Size:
3.32 KB
patch
obsolete
>From 6961a3a72fb9b29f74b9cefc8407cfd7de55dc41 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 6 Mar 2017 12:05:31 +0000 >Subject: [PATCH] Bug 18104 - allow SIP2 field AE (personal name ) to be > customized > >--- > C4/SIP/ILS/Patron.pm | 20 ++++++++++++++++++++ > C4/SIP/Sip/MsgType.pm | 6 +++--- > etc/SIPconfig.xml | 1 + > 3 files changed, 24 insertions(+), 3 deletions(-) > >diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm >index 0012776..07f75dc 100644 >--- a/C4/SIP/ILS/Patron.pm >+++ b/C4/SIP/ILS/Patron.pm >@@ -190,6 +190,26 @@ sub AUTOLOAD { > } > } > >+sub name { >+ my ( $self, $template ) = @_; >+ >+ if ($template) { >+ require Template; >+ require Koha::Patrons; >+ >+ my $tt = Template->new(); >+ >+ my $patron = Koha::Patrons->find( $self->{borrowernumber} ); >+ >+ my $output; >+ $tt->process( \$template, { patron => $patron }, \$output ); >+ return $output; >+ } >+ else { >+ return $self->{name}; >+ } >+} >+ > sub check_password { > my ( $self, $pwd ) = @_; > >diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm >index 9a40442..17ee77a 100644 >--- a/C4/SIP/Sip/MsgType.pm >+++ b/C4/SIP/Sip/MsgType.pm >@@ -420,7 +420,7 @@ sub build_patron_status { > > $resp .= patron_status_string($patron); > $resp .= $lang . timestamp(); >- $resp .= add_field( FID_PERSONAL_NAME, $patron->name ); >+ $resp .= add_field( FID_PERSONAL_NAME, $patron->name( $server->{account}->{ae_field_template} ) ); > > # while the patron ID we got from the SC is valid, let's > # use the one returned from the ILS, just in case... >@@ -956,7 +956,7 @@ sub handle_patron_info { > # while the patron ID we got from the SC is valid, let's > # use the one returned from the ILS, just in case... > $resp .= add_field( FID_PATRON_ID, $patron->id ); >- $resp .= add_field( FID_PERSONAL_NAME, $patron->name ); >+ $resp .= add_field( FID_PERSONAL_NAME, $patron->name( $server->{account}->{ae_field_template} ) ); > > # TODO: add code for the fields > # hold items limit >@@ -1248,7 +1248,7 @@ sub handle_patron_enable { > $resp .= $patron->language . timestamp(); > > $resp .= add_field( FID_PATRON_ID, $patron->id ); >- $resp .= add_field( FID_PERSONAL_NAME, $patron->name ); >+ $resp .= add_field( FID_PERSONAL_NAME, $patron->name( $server->{account}->{ae_field_template} ) ); > if ( defined($patron_pwd) ) { > $resp .= add_field( FID_VALID_PATRON_PWD, sipbool( $patron->check_password($patron_pwd) ) ); > } >diff --git a/etc/SIPconfig.xml b/etc/SIPconfig.xml >index 4b77832..d2a9f9f 100644 >--- a/etc/SIPconfig.xml >+++ b/etc/SIPconfig.xml >@@ -51,6 +51,7 @@ > <login id="lpl-sc-beacock" password="xyzzy" > delimiter="|" error-detect="enabled" institution="LPL" > send_patron_home_library_in_af="1" >+ ae_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]" > da_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]" > av_field_template="[% accountline.description %] [% accountline.amountoutstanding | format('%.2f') %]" > > <screen_msg_regex find="Greetings from Koha." replace="Welcome to your library!" /> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18104
:
60845
|
60876
|
64579
|
64580
|
64581