Attachment 60975 Details for Bug 18215 – Bug 18215: Fix another tls warning

[patch] Bug 18215: Fix another tls warning

Bug-18215-Fix-another-tls-warning.patch (text/plain), 1.19 KB, created by Marcel de Rooy on 2017-03-10 08:21:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-03-10 08:21:42 UTC

Size: 1.19 KB

patch

obsolete

>From 0664ed35760b93eeaa193ec046be286d96231a1e Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 10 Mar 2017 09:17:02 +0100
>Subject: [PATCH] Bug 18215: Fix another tls warning
>Content-Type: text/plain; charset=utf-8
>
>Resolve warning:
>Use of uninitialized value in string eq at C4/Installer.pm line 79.
>
>Test plan:
>Add a trivial .sql file in atomicupdate (comment is sufficient).
>Run updatedatabase.pl
>Without the patch you have the warning.
>Apply the patch and repeat (no warning).
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/Installer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Installer.pm b/C4/Installer.pm
>index e8692a1..866d1f2 100644
>--- a/C4/Installer.pm
>+++ b/C4/Installer.pm
>@@ -76,7 +76,7 @@ sub new {
>     $self->{'user'}     = C4::Context->config("user");
>     $self->{'password'} = C4::Context->config("pass");
>     $self->{'tls'} = C4::Context->config("tls");
>-    if ($self->{'tls'} eq 'yes'){
>+    if( $self->{'tls'} && $self->{'tls'} eq 'yes' ) {
>         $self->{'ca'} = C4::Context->config('ca');
>         $self->{'cert'} = C4::Context->config('cert');
>         $self->{'key'} = C4::Context->config('key');
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18215: 60823 | 60832 | 60844 | 60846 | 60975 | 61005