Attachment 60997 Details for Bug 18211 – Bug 18211: Corrected intended id's in jquery.

[patch] Bug 18211: Corrected intended id's in jquery.

Bug-18211-Corrected-intended-ids-in-jquery.patch (text/plain), 2.49 KB, created by Christopher Brannon on 2017-03-10 15:36:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christopher Brannon

Created: 2017-03-10 15:36:15 UTC

Size: 2.49 KB

patch

obsolete

>From 615a60a2209268c61cd0826631c35340e7d4ca7d Mon Sep 17 00:00:00 2001
>From: Christopher Brannon <cbrannon@cdalibrary.org>
>Date: Fri, 10 Mar 2017 15:26:13 +0000
>Subject: [PATCH] Bug 18211: Corrected intended id's in jquery.
>
>To test:
>1) Checkout items - if you can, have items checked out from previous day
>too, but not necessary.
>2) Review source code and see that the ids on the <tr> and <td> for
>cells containing "Today's checkouts" and "Previous checkouts" labels
>have some crazy ids with partial html tags (strong) and other
>unnecessary elements.
>3) Apply patch.
>4) Examine source code again and see a better and smaller id.
>---
> .../lib/jquery/plugins/jquery.dataTables.rowGrouping.js           | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.dataTables.rowGrouping.js b/koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.dataTables.rowGrouping.js
>index 126ff63..c1670f9 100644
>--- a/koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.dataTables.rowGrouping.js
>+++ b/koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.dataTables.rowGrouping.js
>@@ -121,12 +121,11 @@
>             function fnCreateGroupRow(sGroupCleaned, sGroup, iColspan) {
>                 var nGroup = document.createElement('tr');
>                 var nCell = document.createElement('td');
>-                nGroup.id = "group-id-" + oTable.attr("id") + "_" + sGroupCleaned;
>+                nGroup.id = oTable.attr("id") + "_" + sGroupCleaned;
> 
>                 var oGroup = { id: nGroup.id, key: sGroupCleaned, text: sGroup, level: 0, groupItemClass: ".group-item-" + sGroupCleaned, dataGroup: sGroupCleaned, aoSubgroups: new Array() };
> 
> 
>-
>                 if (properties.bSetGroupingClassOnTR) {
>                     nGroup.className = properties.sGroupingClass + " " + sGroupCleaned;
>                 } else {
>@@ -248,7 +247,8 @@
>             function _fnGetCleanedGroup(sGroup) {
> 
>                 if (sGroup === "") return "-";
>-                return sGroup.toLowerCase().replace(/[^a-zA-Z0-9\u0080-\uFFFF]+/g, "-"); //fix for unicode characters (Issue 23)
>+                sGroup = $(sGroup).text();
>+                return sGroup.toLowerCase().replace(/[^a-zA-Z0-9\'\u0080-\uFFFF]+/g, "-").replace(/[\']+/g, ""); //fix for unicode characters (Issue 23)
>                 //return sGroup.toLowerCase().replace(/\W+/g, "-"); //Fix provided by bmathews (Issue 7)
>             }
> 
>@@ -687,4 +687,4 @@
> 
>         });
>     };
>-})(jQuery);
>\ No newline at end of file
>+})(jQuery);
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18211: 60997 | 78989 | 79001