Attachment 61032 Details for Bug 16246 – Bug 16246: Return all reserves columns in ILS-DI GetRecords response

[patch] Bug 16246: Return all reserves columns in ILS-DI GetRecords response

Bug-16246-Return-all-reserves-columns-in-ILS-DI-Ge.patch (text/plain), 1.69 KB, created by Julian Maurice on 2017-03-13 12:51:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2017-03-13 12:51:52 UTC

Size: 1.69 KB

patch

obsolete

>From a165648898a588dc76ce0f88849ba83fca25d472 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Mon, 11 Apr 2016 16:15:08 +0200
>Subject: [PATCH] Bug 16246: Return all reserves columns in ILS-DI GetRecords
> response
>
>The list of reserves fields returned in ILS-DI GetRecords response is
>arbitrary. Instead we should return all the fields available in reserves
>table
>---
> C4/ILSDI/Services.pm | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm
>index b735d38791..5ef0744b88 100644
>--- a/C4/ILSDI/Services.pm
>+++ b/C4/ILSDI/Services.pm
>@@ -36,6 +36,7 @@ use C4::Auth;
> use C4::Members::Attributes qw(GetBorrowerAttributes);
> 
> use Koha::Libraries;
>+use Koha::Holds;
> 
> =head1 NAME
> 
>@@ -217,7 +218,7 @@ sub GetRecords {
> 
>         # Get most of the needed data
>         my $biblioitemnumber = $biblioitem->{'biblioitemnumber'};
>-        my $reserves         = GetReservesFromBiblionumber({ biblionumber => $biblionumber });
>+        my $reserves         = Koha::Holds->search({ biblionumber => $biblionumber })->unblessed;
>         my $issues           = GetBiblioIssues($biblionumber);
>         my $items            = GetItemsByBiblioitemnumber($biblioitemnumber);
> 
>@@ -234,6 +235,11 @@ sub GetRecords {
>             $item->{'holdingbranchname'} = $holding_library ? $holding_library->branchname : '';
>         }
> 
>+        foreach my $reserve (@$reserves) {
>+            # For backward compatibility
>+            $reserve->{rtimestamp} = $reserve->{timestamp};
>+        }
>+
>         # Hashref building...
>         $biblioitem->{'items'}->{'item'}       = $items;
>         $biblioitem->{'reserves'}->{'reserve'} = $reserves;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 16246: 50143 | 50144 | 56829 | 56830 | 61032 | 61033 | 61329 | 61330