Bugzilla – Attachment 61055 Details for
Bug 18243
Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18243: 16034 follow-up: Conditionally test Koha::ExternalContent::* modules loading
Bug-18243-16034-follow-up-Conditionally-test-KohaE.patch (text/plain), 1.19 KB, created by
Srdjan Jankovic
on 2017-03-13 23:30:45 UTC
(
hide
)
Description:
Bug 18243: 16034 follow-up: Conditionally test Koha::ExternalContent::* modules loading
Filename:
MIME Type:
Creator:
Srdjan Jankovic
Created:
2017-03-13 23:30:45 UTC
Size:
1.19 KB
patch
obsolete
>From 3244282241b46f3e7834806410fd0a2ed5f55c62 Mon Sep 17 00:00:00 2001 >From: Srdjan <srdjan@catalyst.net.nz> >Date: Tue, 14 Mar 2017 12:24:42 +1300 >Subject: [PATCH] Bug 18243: 16034 follow-up: Conditionally test > Koha::ExternalContent::* modules loading > >To test: >1 - Make sure you don't have WebService::ILS installed >2 - prove t/00-load.t >3 - You should get a failure to load module and tests are skipped >4 - Apply patch >5 - prove t/00-load.t >6 - Module is not loaded, test are skipped >Optional: >7 - Install WebService::ILS >5 - prove t/00-load.t >6 - Module is loaded, test passes >--- > t/00-load.t | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/t/00-load.t b/t/00-load.t >index 6c8b838..36a5bcf 100644 >--- a/t/00-load.t >+++ b/t/00-load.t >@@ -89,6 +89,9 @@ sub is_testable { > elsif ( $module_name =~ /Koha::SearchEngine::Elasticsearch::Search/xsm ) { > @needed_module_names = ( 'Catmandu::Store::ElasticSearch' ); > } >+ elsif ( $module_name =~ /^Koha::ExternalContent/xsm ) { >+ @needed_module_names = ( 'WebService::ILS' ); >+ } > foreach my $current_name (@needed_module_names) { > my $relative_pathname = $current_name; > $relative_pathname =~ s/::/\//gxsm; >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18243
:
60974
|
61017
|
61039
|
61055
|
61063
|
61064