Bugzilla – Attachment 61063 Details for
Bug 18243
Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing
Bug-18243-16034-follow-up-better-handling-of-absen.patch (text/plain), 1.63 KB, created by
Jonathan Druart
on 2017-03-14 13:16:10 UTC
(
hide
)
Description:
Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-03-14 13:16:10 UTC
Size:
1.63 KB
patch
obsolete
>From 1edcf97f0d4887e776dee91333f570d21527c2ce Mon Sep 17 00:00:00 2001 >From: Srdjan <srdjan@catalyst.net.nz> >Date: Thu, 2 Mar 2017 13:31:14 +1300 >Subject: [PATCH] Bug 18243: 16034 follow-up: better handling of absence of > WebService::ILS::OverDrive::Patron at testing > >To test: >1 - Make sure you don't have WebService::ILS::OverDrive::Patron >installed >2 - prove t/Koha_ExternalContent_OverDrive.t >3 - You should get a failure to load module and tests are skipped >4 - Apply patch >5 - prove t/Koha_ExternalContent_OverDrive.t >6 - Module is not loaded, test are skipped > >Fixed small typo 'cannot filnd' -> 'cannot find' >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/Koha_ExternalContent_OverDrive.t | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/Koha_ExternalContent_OverDrive.t b/t/Koha_ExternalContent_OverDrive.t >index de70b3d..5d2486f 100755 >--- a/t/Koha_ExternalContent_OverDrive.t >+++ b/t/Koha_ExternalContent_OverDrive.t >@@ -3,11 +3,11 @@ use Modern::Perl; > use t::lib::Mocks; > use Test::More tests => 5; # last test to print > >-local $@; >-eval { require WebService::ILS::OverDrive::Patron; } >- or diag($@); >+use Module::Load::Conditional qw( can_load ); >+ > SKIP: { >- skip "cannot filnd WebService::ILS::OverDrive::Patron", 5 if $@; >+ skip "cannot find WebService::ILS::OverDrive::Patron", 5 >+ unless can_load( modules => { 'WebService::ILS::OverDrive::Patron' => undef } ); > > use_ok('Koha::ExternalContent::OverDrive'); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18243
:
60974
|
61017
|
61039
|
61055
| 61063 |
61064