Attachment 61142 Details for Bug 13757 – Bug 13757: (QA followup) Check DB structure before altering table

[patch] Bug 13757: (QA followup) Check DB structure before altering table

Bug-13757-QA-followup-Check-DB-structure-before-al.patch (text/plain), 2.12 KB, created by Nick Clemens (kidclamp) on 2017-03-15 20:31:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2017-03-15 20:31:05 UTC

Size: 2.12 KB

patch

obsolete

>From 1568767c0b700d19043bd75474c05f3fa7b992f1 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 20 Jan 2017 10:59:27 -0300
>Subject: [PATCH] Bug 13757: (QA followup) Check DB structure before altering
> table
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> ...13757-add_opac_editable_to_borrower_attribute_types.perl | 13 +++++++++++++
> ..._13757-add_opac_editable_to_borrower_attribute_types.sql |  1 -
> 2 files changed, 13 insertions(+), 1 deletion(-)
> create mode 100644 installer/data/mysql/atomicupdate/bug_13757-add_opac_editable_to_borrower_attribute_types.perl
> delete mode 100644 installer/data/mysql/atomicupdate/bug_13757-add_opac_editable_to_borrower_attribute_types.sql
>
>diff --git a/installer/data/mysql/atomicupdate/bug_13757-add_opac_editable_to_borrower_attribute_types.perl b/installer/data/mysql/atomicupdate/bug_13757-add_opac_editable_to_borrower_attribute_types.perl
>new file mode 100644
>index 0000000..1477763
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_13757-add_opac_editable_to_borrower_attribute_types.perl
>@@ -0,0 +1,13 @@
>+$DBversion = "16.12.00.XXX";
>+if ( CheckVersion($DBversion) ) {
>+    unless ( column_exists( 'borrower_attribute_types', 'opac_editable' ) )
>+    {
>+        $dbh->do(q{
>+            ALTER TABLE borrower_attribute_types
>+                ADD COLUMN `opac_editable` tinyint(1) NOT NULL default 0 AFTER `opac_display`
>+        });
>+    }
>+
>+    print "Upgrade to $DBversion done (Bug 13757: Make patron attributes editable in the opac if set to 'editable in OPAC'\n";
>+    SetVersion($DBversion);
>+}
>diff --git a/installer/data/mysql/atomicupdate/bug_13757-add_opac_editable_to_borrower_attribute_types.sql b/installer/data/mysql/atomicupdate/bug_13757-add_opac_editable_to_borrower_attribute_types.sql
>deleted file mode 100644
>index 76a989f..0000000
>--- a/installer/data/mysql/atomicupdate/bug_13757-add_opac_editable_to_borrower_attribute_types.sql
>+++ /dev/null
>@@ -1 +0,0 @@
>-ALTER TABLE borrower_attribute_types ADD COLUMN `opac_editable` tinyint(1) NOT NULL default 0 AFTER `opac_display`;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 13757: 42254 | 42626 | 42627 | 47625 | 48040 | 48041 | 48042 | 48043 | 48379 | 48380 | 48381 | 48382 | 56924 | 56925 | 56926 | 56927 | 56928 | 56929 | 57041 | 57042 | 57043 | 57044 | 57045 | 57046 | 58252 | 58253 | 58254 | 58255 | 58351 | 58352 | 58353 | 58354 | 58355 | 58356 | 58357 | 58428 | 58429 | 58581 | 58703 | 58706 | 58707 | 58708 | 58709 | 58710 | 58711 | 58712 | 58713 | 58714 | 58715 | 59376 | 59737 | 59738 | 59739 | 59813 | 59896 | 59897 | 59898 | 60359 | 60360 | 61132 | 61133 | 61134 | 61135 | 61136 | 61137 | 61138 | 61139 | 61140 | 61141 | 61142 | 61143 | 61144 | 61145 | 61146 | 61147 | 61148 | 61149 | 61150 | 61492 | 61493 | 61555 | 61556 | 61557 | 61558 | 61559 | 61560 | 61561 | 61562 | 61563 | 61564 | 61565 | 61566 | 61567 | 61568 | 61569 | 61570 | 61571 | 61572 | 61573 | 61574 | 61575