Bugzilla – Attachment 61150 Details for
Bug 13757
Make patron attributes editable in the opac if set to 'editable in OPAC'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13757: Attribute with value 0 should be stored
Bug-13757-Attribute-with-value-0-should-be-stored.patch (text/plain), 2.56 KB, created by
Nick Clemens (kidclamp)
on 2017-03-15 20:32:05 UTC
(
hide
)
Description:
Bug 13757: Attribute with value 0 should be stored
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-03-15 20:32:05 UTC
Size:
2.56 KB
patch
obsolete
>From f4e12de9a599b3c9fb8202f0c790d6a80a43d26e Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 16 Feb 2017 16:02:48 -0300 >Subject: [PATCH] Bug 13757: Attribute with value 0 should be stored > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > Koha/Patron/Modification.pm | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/Koha/Patron/Modification.pm b/Koha/Patron/Modification.pm >index 718ffe4..78f092d 100644 >--- a/Koha/Patron/Modification.pm >+++ b/Koha/Patron/Modification.pm >@@ -54,8 +54,7 @@ sub store { > )->count() > ) > { >- Koha::Exceptions::Patron::Modification::DuplicateVerificationToken >- ->throw( >+ Koha::Exceptions::Patron::Modification::DuplicateVerificationToken->throw( > "Duplicate verification token " . $self->verification_token ); > } > } >@@ -74,7 +73,6 @@ sub store { > return $self->SUPER::store(); > } > >- > =head2 approve > > $m->approve(); >@@ -106,8 +104,7 @@ sub approve { > > # Take care of extended attributes > if ( $self->extended_attributes ) { >- $extended_attributes >- = try { decode_json( $self->extended_attributes ) } >+ $extended_attributes = try { decode_json( $self->extended_attributes ) } > catch { > Koha::Exceptions::Patron::Modification::InvalidData->throw( > 'The passed extended_attributes is not valid JSON'); >@@ -136,13 +133,17 @@ sub approve { > attribute => $attr->{value} > } > )->store >- if $attr->{value}; >+ if $attr->{value} # there's a value >+ or >+ ( defined $attr->{value} # there's a value that is 0, and not >+ && $attr->{value} ne "" # the empty string which means delete >+ && $attr->{value} == 0 >+ ); > } > } > catch { > if ( $_->isa('DBIx::Class::Exception') ) { >- Koha::Exceptions::Patron::Modification->throw( >- $_->{msg} ); >+ Koha::Exceptions::Patron::Modification->throw( $_->{msg} ); > } > else { > Koha::Exceptions::Patron::Modification->throw($@); >@@ -154,7 +155,6 @@ sub approve { > return $self->delete(); > } > >- > =head3 type > > =cut >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13757
:
42254
|
42626
|
42627
|
47625
|
48040
|
48041
|
48042
|
48043
|
48379
|
48380
|
48381
|
48382
|
56924
|
56925
|
56926
|
56927
|
56928
|
56929
|
57041
|
57042
|
57043
|
57044
|
57045
|
57046
|
58252
|
58253
|
58254
|
58255
|
58351
|
58352
|
58353
|
58354
|
58355
|
58356
|
58357
|
58428
|
58429
|
58581
|
58703
|
58706
|
58707
|
58708
|
58709
|
58710
|
58711
|
58712
|
58713
|
58714
|
58715
|
59376
|
59737
|
59738
|
59739
|
59813
|
59896
|
59897
|
59898
|
60359
|
60360
|
61132
|
61133
|
61134
|
61135
|
61136
|
61137
|
61138
|
61139
|
61140
|
61141
|
61142
|
61143
|
61144
|
61145
|
61146
|
61147
|
61148
|
61149
|
61150
|
61492
|
61493
|
61555
|
61556
|
61557
|
61558
|
61559
|
61560
|
61561
|
61562
|
61563
|
61564
|
61565
|
61566
|
61567
|
61568
|
61569
|
61570
|
61571
|
61572
|
61573
|
61574
|
61575