Bugzilla – Attachment 61175 Details for
Bug 18283
Display improvements on report results - hide code and change wording
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18283 - Display improvements on report results - hide code and change wording
Bug-18283---Display-improvements-on-report-results.patch (text/plain), 2.37 KB, created by
Nick Clemens (kidclamp)
on 2017-03-16 15:39:13 UTC
(
hide
)
Description:
Bug 18283 - Display improvements on report results - hide code and change wording
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-03-16 15:39:13 UTC
Size:
2.37 KB
patch
obsolete
>From 445279bc05cfd8474ca6d6fb7bce26d5e565413e Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 16 Mar 2017 11:28:29 -0400 >Subject: [PATCH] Bug 18283 - Display improvements on report results - hide > code and change wording > >This patch makes small display improvements to the report results page. > >-Add toggle link for SQL code >-Change results count wording >-Add 'Notes:' label report notes > >To test: >1 - Apply patch >2 - Run some reports >3 - Check that results page makes sense >4 - Hide and display code and ensure toggle works >--- > .../prog/en/modules/reports/guided_reports_start.tt | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index ad53c08..ddda52c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -172,6 +172,12 @@ $("#delColumn").on("click",function(){ > }); > [% END %] > >+ $(".toggle_sql").click(function(){ >+ $("#sql_output").toggle(); >+ $("#toggle_sql_hid").toggle(); >+ $("#toggle_sql_vis").toggle(); >+ }); >+ > $("#table_reports").delegate(".confirmdelete", 'click', function(){ > $(this).parents('tr').attr("class","warn"); > if(confirm(_("Are you sure you want to delete this saved report?"))){ >@@ -822,9 +828,12 @@ canned reports and writing custom SQL reports.</p> > > [% IF ( execute ) %] > <h1>[% name %]</h1> >-[% IF ( notes ) %]<p>[% notes %]</p>[% END %] >-[% IF ( unlimited_total ) %]<p>Total number of rows matching the (unlimited) query is [% unlimited_total %].</p>[% END %] >-<pre id="sql_output">[% sql |html %]</pre> >+[% IF ( notes ) %]<p>Notes: [% notes %]</p>[% END %] >+[% IF ( unlimited_total ) %]<p>Total number of results [% unlimited_total %][% IF unlimited_total > limit %] ([% limit %] shown)[% END %].</p>[% END %] >+<a class="toggle_sql" id="toggle_sql_hid" href="#">Show sql code</a> >+<a class="toggle_sql" id="toggle_sql_vis" href="#" style="display:none;">Hide sql code</a> >+<pre id="sql_output" style="display:none;">[% sql |html %]</pre> >+</br> > > <form action="/cgi-bin/koha/reports/guided_reports.pl" method="get" id="limitselect"> > <input type="hidden" name="phase" value="Run this report"/> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18283
:
61175
|
61192
|
61207
|
61249
|
61253
|
61318
|
61359
|
61360