Attachment 61197 Details for Bug 17005 – Bug 17005 - REST API: add routes to list checkouts history - Followup1. Fix date_due timeformat in tests.

[patch] Bug 17005 - REST API: add routes to list checkouts history - Followup1. Fix date_due timeformat in tests.

Bug-17005---REST-API-add-routes-to-list-checkouts-.patch (text/plain), 1.23 KB, created by Olli-Antti Kivilahti on 2017-03-17 07:33:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olli-Antti Kivilahti

Created: 2017-03-17 07:33:50 UTC

Size: 1.23 KB

patch

obsolete

>From 9874c0d47b9992c9a03f9408ad6fbd3b602c7d31 Mon Sep 17 00:00:00 2001
>From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
>Date: Fri, 17 Mar 2017 09:32:48 +0200
>Subject: [PATCH] Bug 17005 - REST API: add routes to list checkouts history -
> Followup1. Fix date_due timeformat in tests.
>
>---
> t/db_dependent/api/v1/checkoutshistory.t | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/api/v1/checkoutshistory.t b/t/db_dependent/api/v1/checkoutshistory.t
>index 1605199..fe61dd5 100644
>--- a/t/db_dependent/api/v1/checkoutshistory.t
>+++ b/t/db_dependent/api/v1/checkoutshistory.t
>@@ -129,13 +129,14 @@ $t->request_ok($tx)
>   ->json_hasnt('/1')
>   ->json_hasnt('/error');
> 
>+my $date_due_regexp = $date_due1->ymd . 'T' . $date_due1->hms . '\+' .'\d\d:\d\d';
> $tx = $t->ua->build_tx(GET => "/api/v1/checkouts/history/" . $issue1->issue_id);
> $tx->req->cookies({name => 'CGISESSID', value => $session->id});
> $t->request_ok($tx)
>   ->status_is(200)
>   ->json_is('/borrowernumber' => $borrowernumber)
>   ->json_is('/itemnumber' => $itemnumber1)
>-  ->json_is('/date_due' => $date_due1->ymd . ' ' . $date_due1->hms)
>+  ->json_like('/date_due' => qr/$date_due_regexp/)
>   ->json_hasnt('/error');
> 
> $issue1->delete();
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 17005: 53843 | 53851 | 53852 | 53858 | 54198 | 56698 | 56699 | 61197 | 87254 | 87255 | 87383 | 87384 | 87385 | 87405 | 87406 | 87407 | 87442 | 87443 | 87444 | 87447 | 87448 | 87449 | 88263 | 88264 | 88265 | 88329 | 88330 | 88331 | 91166 | 91167 | 91168 | 91235 | 91236 | 91237 | 91238 | 93757 | 93758 | 93759 | 93760