Bugzilla – Attachment 61214 Details for
Bug 7728
Fixing subscription endddate inconsistency: should be empty when the subscription is running
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7728: QA fixes
Bug-7728-QA-fixes.patch (text/plain), 1.90 KB, created by
Marcel de Rooy
on 2017-03-17 12:40:45 UTC
(
hide
)
Description:
Bug 7728: QA fixes
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-03-17 12:40:45 UTC
Size:
1.90 KB
patch
obsolete
>From b03d7dbc943c024289822d84cc670fb0feb754e4 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Wed, 11 Jan 2017 14:51:43 +0100 >Subject: [PATCH] Bug 7728: QA fixes >Content-Type: text/plain; charset=utf-8 > >- Remove useless comments >- Use Koha::Objects::find instead of Koha::Objects::search > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Serials/ReNewSubscription.t | 18 ++++-------------- > 1 file changed, 4 insertions(+), 14 deletions(-) > >diff --git a/t/db_dependent/Serials/ReNewSubscription.t b/t/db_dependent/Serials/ReNewSubscription.t >index 21e06e0..43cc4e8 100644 >--- a/t/db_dependent/Serials/ReNewSubscription.t >+++ b/t/db_dependent/Serials/ReNewSubscription.t >@@ -26,25 +26,15 @@ use Test::MockModule; > use t::lib::TestBuilder; > use t::lib::Mocks; > >-use C4::Context; >-use Koha::Database; > use C4::Serials; > >+use Koha::Database; >+use Koha::Subscription::Histories; >+ > my $schema = Koha::Database->new->schema; > $schema->storage->txn_begin; > > my $builder = t::lib::TestBuilder->new(); >-#my $library = $builder->build({ >-# source => 'Subscription', >-#}); >- >-#my $mContext = new Test::MockModule('C4::Context'); >-#$mContext->mock( 'userenv', sub { >-# return { branch => $library->{branchcode} }; >-#}); >- >- >-#my $dbh = C4::Context->dbh; # after start transaction of testbuilder > > # create fake numberpattern & fake periodicity > my $frequency = $builder->build({ >@@ -95,7 +85,7 @@ my $subscriptionhistory = $builder->build({ > > # Renew the subscription and check that enddate has not been set > ReNewSubscription($subscription->{subscriptionid},'',"2016-01-01",'','',12,''); >-my @history = Koha::Subscription::Histories->search( {subscriptionid => $subscription->{subscriptionid} } ); >+my @history = Koha::Subscription::Histories->find($subscription->{subscriptionid}); > > is ( $history[0]->histenddate(), undef, 'subscription history not empty after renewal'); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7728
:
8240
|
45529
|
45776
|
47303
|
58813
|
58814
|
58815
|
61212
|
61213
| 61214 |
61215