Attachment 61261 Details for Bug 18246 – Bug 18246: Patron card creator: Unit not always displays properly in layouts

[patch] Bug 18246: Patron card creator: Unit not always displays properly in layouts

Bug-18246-Patron-card-creator-Unit-not-always-disp.patch (text/plain), 1.20 KB, created by Jesse Maseto on 2017-03-20 10:49:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jesse Maseto

Created: 2017-03-20 10:49:52 UTC

Size: 1.20 KB

patch

obsolete

>From eec871f54a68d129ec6492fb91d11a4ea47fb15a Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Sat, 11 Mar 2017 19:17:37 +0100
>Subject: [PATCH] Bug 18246: Patron card creator: Unit not always displays
> properly in layouts
>
>To reproduce:
>
>1) Create a new layout
>2) Select an unit in "Units selection"
>3) Save
>4) Edit layout again
>5) Select other unit, e.g. 'SI Centimeter'
>6) Save
>7) Repeat
>8) Edit again
>Error: Latest unit seems to stick and can no longer be changed, because
>in units drop down, multiple untis are marked as selected.
>
>To test:
>1) Apply patch
>2) Repeat steps above, verify that value for units always display as expected.
>
>Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
>---
> patroncards/edit-layout.pl | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/patroncards/edit-layout.pl b/patroncards/edit-layout.pl
>index 81df878..fb495b1 100755
>--- a/patroncards/edit-layout.pl
>+++ b/patroncards/edit-layout.pl
>@@ -146,6 +146,8 @@ if ($op eq 'edit') {
>     foreach my $unit (@$units){
>         if ($unit->{'type'} eq $layout->get_attr('units')) {
>             $unit->{'selected'} = 1;
>+        } else {
>+            $unit->{'selected'} = 0;
>         }
>     }
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18246: 61011 | 61261 | 61352