Attachment 61347 Details for Bug 17758 – [SIGNED-OFF] Bug 17758 - SIP checkin does not handle holds correctly

[patch] [SIGNED-OFF] Bug 17758 - SIP checkin does not handle holds correctly

SIGNED-OFF-Bug-17758---SIP-checkin-does-not-handle.patch (text/plain), 1.91 KB, created by Srdjan Jankovic on 2017-03-21 01:22:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Srdjan Jankovic

Created: 2017-03-21 01:22:38 UTC

Size: 1.91 KB

patch

obsolete

>From 354114a366002bdd7a1abf7bedc557e94e2bee12 Mon Sep 17 00:00:00 2001
>From: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
>Date: Tue, 13 Dec 2016 13:38:19 +0100
>Subject: [PATCH] [SIGNED-OFF] Bug 17758 - SIP checkin does not handle holds
> correctly
>
>This patch updates SIP checkin to use reserve_id as param, to fix regression
>introduced by Bug 14695.
>
>To test:
>
>Given 1 patron and 1 biblio with two items attached:
>
>1) create two record level holds on one biblio on same user
>Using SIP client or telnet:
>2) checkin item x on pickup branch, observe item is waiting and hold 1 is filled
>3) checkin item y on pickup branch, observe item y now is waiting and x is available
>4) apply this patch and repeat 1-3, now expected behaviour should be
>   that both holds are filled and both items waiting
>
>Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
>---
> C4/SIP/ILS/Transaction/Checkin.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm
>index bc1c433..ad04a88 100644
>--- a/C4/SIP/ILS/Transaction/Checkin.pm
>+++ b/C4/SIP/ILS/Transaction/Checkin.pm
>@@ -100,12 +100,12 @@ sub do_checkin {
>         if ($branch eq $messages->{ResFound}->{branchcode}) {
>             $self->alert_type('01');
>             ModReserveAffect( $messages->{ResFound}->{itemnumber},
>-                $messages->{ResFound}->{borrowernumber}, 0);
>+                $messages->{ResFound}->{borrowernumber}, 0, $messages->{ResFound}->{reserve_id});
> 
>         } else {
>             $self->alert_type('02');
>             ModReserveAffect( $messages->{ResFound}->{itemnumber},
>-                $messages->{ResFound}->{borrowernumber}, 1);
>+                $messages->{ResFound}->{borrowernumber}, 1, $messages->{ResFound}->{reserve_id});
>             ModItemTransfer( $messages->{ResFound}->{itemnumber},
>                 $branch,
>                 $messages->{ResFound}->{branchcode}
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 17758: 58154 | 61347 | 61686