Attachment 61348 Details for Bug 14535 – [SIGNED-OFF] Bug 14535: Late orders does not show orders with price = 0

[patch] [SIGNED-OFF] Bug 14535: Late orders does not show orders with price = 0

SIGNED-OFF-Bug-14535-Late-orders-does-not-show-ord.patch (text/plain), 1.35 KB, created by Srdjan Jankovic on 2017-03-21 01:40:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Srdjan Jankovic

Created: 2017-03-21 01:40:53 UTC

Size: 1.35 KB

patch

obsolete

>From ffcae67ecc2a2f9798a64bb95baf2d9afcf2a5e6 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 6 Feb 2017 10:04:57 +0100
>Subject: [PATCH] [SIGNED-OFF] Bug 14535: Late orders does not show orders with
> price = 0
>
>This patch removes the filter of unitpricesupplier <> 0 and
>unitpricelib <> 0 from GetLateOrders as used in lateorders.pl.
>This allows you to claim late orders without a price entered.
>
>Test plan:
>[1] Run t/db_dependent/Acquisition.t
>[2] Check if you see an order with no price in lateorders.pl. (If needed,
>    remove prices from a few orders.)
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
>---
> C4/Acquisition.pm | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
>diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
>index c113c16..333d533 100644
>--- a/C4/Acquisition.pm
>+++ b/C4/Acquisition.pm
>@@ -2087,11 +2087,7 @@ sub GetLateOrders {
>             $from .= " AND (closedate <= DATE_SUB(CAST(now() AS date),INTERVAL ? DAY)) " ;
>             push @query_params, $delay;
>         }
>-        $having = "
>-        HAVING quantity          <> 0
>-            AND unitpricesupplier <> 0
>-            AND unitpricelib      <> 0
>-        ";
>+        $having = "HAVING quantity <> 0";
>     } else {
>         # FIXME: account for IFNULL as above
>         $select .= "
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 14535: 59921 | 59922 | 59928 | 61348 | 61349 | 61370 | 61371