Bugzilla – Attachment 61370 Details for
Bug 14535
Late orders does not show orders with price = 0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14535: Late orders does not show orders with price = 0
Bug-14535-Late-orders-does-not-show-orders-with-pr.patch (text/plain), 1.41 KB, created by
Jonathan Druart
on 2017-03-21 11:40:47 UTC
(
hide
)
Description:
Bug 14535: Late orders does not show orders with price = 0
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-03-21 11:40:47 UTC
Size:
1.41 KB
patch
obsolete
>From fc87505092b312cae5ba95d5e79892ca078fc966 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 6 Feb 2017 10:04:57 +0100 >Subject: [PATCH] Bug 14535: Late orders does not show orders with price = 0 > >This patch removes the filter of unitpricesupplier <> 0 and >unitpricelib <> 0 from GetLateOrders as used in lateorders.pl. >This allows you to claim late orders without a price entered. > >Test plan: >[1] Run t/db_dependent/Acquisition.t >[2] Check if you see an order with no price in lateorders.pl. (If needed, > remove prices from a few orders.) > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Acquisition.pm | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index c113c16..333d533 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -2087,11 +2087,7 @@ sub GetLateOrders { > $from .= " AND (closedate <= DATE_SUB(CAST(now() AS date),INTERVAL ? DAY)) " ; > push @query_params, $delay; > } >- $having = " >- HAVING quantity <> 0 >- AND unitpricesupplier <> 0 >- AND unitpricelib <> 0 >- "; >+ $having = "HAVING quantity <> 0"; > } else { > # FIXME: account for IFNULL as above > $select .= " >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14535
:
59921
|
59922
|
59928
|
61348
|
61349
| 61370 |
61371