Bugzilla – Attachment 6139 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6679 : Adding license statement and stopping declaring variables in a conditional
Bug-6679--Adding-license-statement-and-stopping-de.patch (text/plain), 2.88 KB, created by
Chris Cormack
on 2011-11-02 03:02:32 UTC
(
hide
)
Description:
Bug 6679 : Adding license statement and stopping declaring variables in a conditional
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2011-11-02 03:02:32 UTC
Size:
2.88 KB
patch
obsolete
>From dbb402935cda3d5100703eae791177940ef697bd Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Wed, 2 Nov 2011 15:55:00 +1300 >Subject: [PATCH] Bug 6679 : Adding license statement and stopping declaring > variables in a conditional > >--- > labels/label-create-csv.pl | 27 ++++++++++++++++++++++++--- > t/00-testcritic.t | 4 ++-- > 2 files changed, 26 insertions(+), 5 deletions(-) > >diff --git a/labels/label-create-csv.pl b/labels/label-create-csv.pl >index 50262df..6e2263f 100755 >--- a/labels/label-create-csv.pl >+++ b/labels/label-create-csv.pl >@@ -1,5 +1,23 @@ > #!/usr/bin/perl > >+# Copyright Koha development team 2011 >+# >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 2 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along with >+# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, >+# Suite 330, Boston, MA 02111-1307 USA >+# >+ > use strict; > use warnings; > >@@ -13,11 +31,14 @@ use C4::Labels 1.000000; > > my $cgi = new CGI; > >-my $batch_id = $cgi->param('batch_id') if $cgi->param('batch_id'); >+my $batch_id; >+my @label_ids; >+my @item_numbers; >+$batch_id = $cgi->param('batch_id') if $cgi->param('batch_id'); > my $template_id = $cgi->param('template_id') || undef; > my $layout_id = $cgi->param('layout_id') || undef; >-my @label_ids = $cgi->param('label_id') if $cgi->param('label_id'); >-my @item_numbers = $cgi->param('item_number') if $cgi->param('item_number'); >+@label_ids = $cgi->param('label_id') if $cgi->param('label_id'); >+@item_numbers = $cgi->param('item_number') if $cgi->param('item_number'); > > my $items = undef; > >diff --git a/t/00-testcritic.t b/t/00-testcritic.t >index aad6471..6018502 100755 >--- a/t/00-testcritic.t >+++ b/t/00-testcritic.t >@@ -16,8 +16,8 @@ my @all_koha_dirs = qw( acqui admin authorities basket C4 catalogue cataloguing > labels members misc offline_circ opac patroncards reports reserve reviews rotating_collections > serials sms suggestion t tags test tools virtualshelves); > >-my @dirs = qw( acqui admin authorities basket catalogue cataloguing circ debian errors offline_circ reserve >- reviews rotating_collections serials sms virtualshelves ); >+my @dirs = qw( acqui admin authorities basket catalogue cataloguing circ debian errors labels >+ offline_circ reserve reviews rotating_collections serials sms virtualshelves ); > > if ( not $ENV{TEST_QA} ) { > my $msg = 'Author test. Set $ENV{TEST_QA} to a true value to run'; >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208