Attachment 6141 Details for Bug 6679 – Bug 6679 : Don't declare variables in conditionals Don't change $_ in a list context http://search.cpan.org/~elliotjs/Perl-Critic-1.116/lib/Perl/Critic/Policy/ControlStructures/ProhibitMutatingListFunctions.pm

[patch] Bug 6679 : Don't declare variables in conditionals Don't change $_ in a list context http://search.cpan.org/~elliotjs/Perl-Critic-1.116/lib/Perl/Critic/Policy/ControlStructures/ProhibitMutatingListFunctions.pm

Bug-6679--Dont-declare-variables-in-conditionals-D.patch (text/plain), 2.44 KB, created by Chris Cormack on 2011-11-02 03:14:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2011-11-02 03:14:18 UTC

Size: 2.44 KB

patch

obsolete

>From 997c6ebfa98084ad593134ccb6825cfdab05d28c Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Wed, 2 Nov 2011 16:13:20 +1300
>Subject: [PATCH] Bug 6679 : Don't declare variables in conditionals Don't
> change $_ in a list context
> http://search.cpan.org/~elliotjs/Perl-Critic-1.116/lib/Perl/Critic/Policy/ControlStructures/ProhibitMutatingListFunctions.pm
>
>---
> labels/label-print.pl |   15 +++++++++------
> 1 files changed, 9 insertions(+), 6 deletions(-)
>
>diff --git a/labels/label-print.pl b/labels/label-print.pl
>index 5cab284..5da731b 100755
>--- a/labels/label-print.pl
>+++ b/labels/label-print.pl
>@@ -41,12 +41,15 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
> );
> 
> my $op = $cgi->param('op') || 'none';
>-my @label_ids = $cgi->param('label_id') if $cgi->param('label_id');   # this will handle individual label printing
>-my @batch_ids = $cgi->param('batch_id') if $cgi->param('batch_id');
>+my @label_ids;
>+@label_ids = $cgi->param('label_id') if $cgi->param('label_id');   # this will handle individual label printing
>+my @batch_ids;
>+@batch_ids = $cgi->param('batch_id') if $cgi->param('batch_id');
> my $layout_id = $cgi->param('layout_id') || undef;
> my $template_id = $cgi->param('template_id') || undef;
> my $start_label = $cgi->param('start_label') || 1;
>-my @item_numbers = $cgi->param('item_number') if $cgi->param('item_number');
>+my @item_numbers;
>+@item_numbers = $cgi->param('item_number') if $cgi->param('item_number');
> my $output_format = $cgi->param('output_format') || 'pdf';
> my $referer = $cgi->param('referer') || undef;
> 
>@@ -109,9 +112,9 @@ elsif ($op eq 'none') {
>     # setup select menus for selecting layout and template for this run...
>     $referer = $ENV{'HTTP_REFERER'};
>     $referer =~ s/^.*?:\/\/.*?(\/.*)$/$1/m;
>-    @batch_ids = grep{$_ = {batch_id => $_}} @batch_ids;
>-    @label_ids = grep{$_ = {label_id => $_}} @label_ids;
>-    @item_numbers = grep{$_ = {item_number => $_}} @item_numbers;
>+    @batch_ids = grep{my $id = $_; $id = {batch_id => $id}} @batch_ids;
>+    @label_ids = grep{my $id = $_; $id = {label_id => $id}} @label_ids;
>+    @item_numbers = grep{my $number=$_; $number = {item_number => $number}} @item_numbers;
>     $templates = get_all_templates(field_list => 'template_id, template_code', filter => 'creator = "Labels"');
>     $layouts = get_all_layouts(field_list => 'layout_id, layout_name', filter => 'creator = "Labels"');
>     $output_formats = get_output_formats();
>-- 
>1.7.5.4

Actions: View | Diff | Splinter Review

Attachments on bug 6679: 4883 | 4884 | 4885 | 4886 | 4887 | 4888 | 5445 | 5446 | 5483 | 5487 | 6121 | 6122 | 6123 | 6139 | 6140 | 6141 | 6142 | 6143 | 6144 | 6270 | 6271 | 6663 | 6670 | 6675 | 6676 | 6677 | 6678 | 8542 | 8897 | 8898 | 8899 | 8950 | 8951 | 9746 | 9747 | 9748 | 9749 | 9750 | 10050 | 10051 | 10052 | 10053 | 10054 | 10075 | 10076 | 10077 | 10078 | 10079 | 10484 | 10485 | 10486 | 10487 | 10488 | 10489 | 10491 | 10492 | 10493 | 10494 | 10495 | 10496 | 10497 | 10499 | 10500 | 10501 | 10502 | 10503 | 10504 | 10505 | 10506 | 10507 | 10508 | 10509 | 10510 | 10512 | 10513 | 10514 | 10515 | 10517 | 10521 | 10522 | 10523 | 10524 | 10525 | 10526 | 10527 | 10935 | 10936 | 10938 | 10940 | 10944 | 10945 | 10946 | 10947 | 10948 | 10949 | 10950 | 10952 | 10953 | 10955 | 10957 | 10958 | 10959 | 10960 | 10961 | 10962 | 10963 | 10964 | 10965 | 10966 | 10967 | 10972 | 10976 | 10979 | 10980 | 10981 | 12224 | 12363 | 12490 | 12491 | 12492 | 34191 | 34192 | 34193 | 34194 | 34195 | 34196 | 34197 | 39100 | 39101 | 39102 | 39392 | 39393 | 39394 | 39395 | 39396 | 39397 | 39398 | 42770 | 47086 | 47087 | 47088 | 47089 | 47090 | 47178 | 47179 | 47180 | 47181 | 47205 | 47206 | 47207 | 47208