Bugzilla – Attachment 61439 Details for
Bug 18266
Internal Server Error when paying fine for lost item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18266: Fix internal error when paying fine for lost item without.. item
Bug-18266-Fix-internal-error-when-paying-fine-for-.patch (text/plain), 1.59 KB, created by
Marc Véron
on 2017-03-22 10:33:38 UTC
(
hide
)
Description:
Bug 18266: Fix internal error when paying fine for lost item without.. item
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2017-03-22 10:33:38 UTC
Size:
1.59 KB
patch
obsolete
>From d6c2df1e3453d3a2de54cb91cdc1f437e9a46491 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 21 Mar 2017 12:24:28 -0300 >Subject: [PATCH] Bug 18266: Fix internal error when paying fine for lost item > without.. item >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >If a fine is created for a lost item but the itemnumber is not supplied, >the system will return it. >The item should not be mark as returned if there is no item linked to >the fine. > >Test plan: >1. Turn StoreLastBorrower on >2. Create a manual invoice for a lost item, do not supply a barcode >3. Pay the fines 'Pay fines > Pay' > >=> Without this patch applied you get >Can't call method "last_returned_by" on an undefined value at >/home/marc/koha/C4/Circulation.pm line 2188. > >=> With this patch applied, you must not get the error. > >Signed-off-by: Marc Véron <veron@veron.ch> >--- > Koha/Account.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Account.pm b/Koha/Account.pm >index 28b789f..9ec1c1b 100644 >--- a/Koha/Account.pm >+++ b/Koha/Account.pm >@@ -101,7 +101,7 @@ sub pay { > $fine->amountoutstanding($new_amountoutstanding)->store(); > $balance_remaining = $balance_remaining - $amount_to_pay; > >- if ( $fine->accounttype && ( $fine->accounttype eq 'Rep' || $fine->accounttype eq 'L' ) ) >+ if ( $fine->itemnumber && $fine->accounttype && ( $fine->accounttype eq 'Rep' || $fine->accounttype eq 'L' ) ) > { > C4::Circulation::ReturnLostItem( $self->{patron_id}, $fine->itemnumber ); > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18266
:
61402
|
61439
|
61687
|
61795