Attachment 61441 Details for Bug 18307 – Bug 18307 - Branchname is no more displayed in subscription tab wiew

[patch] Bug 18307 - Branchname is no more displayed in subscription tab wiew

Bug-18307---Branchname-is-no-more-displayed-in-sub.patch (text/plain), 2.37 KB, created by Claire Gravely on 2017-03-22 13:05:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Claire Gravely

Created: 2017-03-22 13:05:10 UTC

Size: 2.37 KB

patch

obsolete

>From 11c34baf1a56eed439fd515ed905e388fe2203b2 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Tue, 21 Mar 2017 14:52:51 +0100
>Subject: [PATCH] Bug 18307 - Branchname is no more displayed in subscription
> tab wiew
>
>This patch restores the branchname in OPAC subscription detail view.
>Additionally, it adds the subscriptons count to the tab title to make
>it consistent with the other tab titles.
>
>To test:
>- Search a subscription in OPAC catalog
>- Go to Subscriptions tab (see screenshot in initial comment)
>- Verify that library name does not display
>- Apply patch
>- Verify that library name displays properly in Subscriptons tab
>- Verify that the tab title displays the subscriptions count
>  e.g.: Subscriptions (2)
>
>Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index e4fb61f..5e76914 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -576,7 +576,7 @@
> 
>                         [% IF ( subscriptionsnumber ) %]
>                             [% IF ( defaulttab == 'subscriptions' ) %]<li id="tab_subscriptions" class="ui-tabs-active">[% ELSE %]<li id="tab_subscriptions">[% END %]
>-                                <a href="#subscriptions">Subscriptions</a>
>+                                <a href="#subscriptions">Subscriptions ( [% subscriptionsnumber %] ) </a>
>                             </li>
>                         [% END %]
> 
>@@ -796,7 +796,7 @@
>                             <p>There are [% subscriptionsnumber %] subscription(s) associated with this title.</p>
>                             [% FOREACH subscription IN subscriptions %]
>                                 [% IF ( subscription.branchcode ) %]
>-                                    <h3>At library: [% Branches.GetName( subscription.branchname ) %]</h3>
>+                                    <h3>At library: [% Branches.GetName( subscription.branchcode ) %]</h3>
>                                 [% ELSE %]
>                                     [% IF ( subscription.branchcode ) %]
>                                         <h3>At library: [% subscription.branchcode %]</h3>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18307: 61354 | 61389 | 61441 | 61459